Status Update
Comments
il...@google.com <il...@google.com> #2
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)
Android bug report capturing (kindly share complete bugreport)
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory.
Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
ga...@google.com <ga...@google.com> #3
Sample: N/A - it's a race condition can't reproduce it consistently
Frequency: ~1 %
Android bug report capturing: N/A - firebase crashlytics doesn't provide that information
Problem:
In BiometricFragment the mBundle is not always set - so when isDeviceCredentialAllowed is called the mBundle.getBoolean(BiometricPrompt.KEY_ALLOW_DEVICE_CREDENTIAL, false) throws the NullPointerException.
ap...@google.com <ap...@google.com> #4
Branch: androidx-master-dev
commit 0b2dee89f68e9ed41c9552a93fee72364253af41
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Nov 06 10:00:17 2019
Fix possible NPE with BiometricFragment method
The current implementation of
BiometricFragment#setDeviceCredentialAllowed() tries to get a boolean
from mBundle without first checking to see if mBundle is null,
potentially resulting in a NullPointerException. This commit adds in the
null check in order to make calling this method safer. It also adds a
unit test case to exercise this behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 142599311
Change-Id: I18e03f926ff03c53f8cf1812fbad46ea75db6a32
M biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
ap...@google.com <ap...@google.com> #5
ap...@google.com <ap...@google.com> #6
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to activity/activity/api/current.txt
- androidx.activity
- androidx.activity.BackEventCompat
- androidx.activity.BackEventCompat.Companion
[Gerrit:https://android-review.googlesource.com/3548541]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:activity/activity/api/current.txt]
jb...@google.com <jb...@google.com> #7
This has been added internally and will be available in the Activity 1.11.0-alpha02
release.
Description
Component used: activity-compose -
PredictiveBackHandler
Right now, when getting the progress events, you can tell the
touchX
andtouchY
and the progress, but you’d need to manually track the velocity to understand the velocity with which a gesture is performed.I’d like this velocity to be able to use
animateDecay
, oranimateTo()
onAnimatable
, to be able to smoothly finish the animation from where it left off. To do this, I’ve addedVelocityTracker
, but the BackEvent doesn’t containuptimeMillis
, leading me to useSystem.currentTimeMillis
, which could be inaccurate if an event comes in a different order.