Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 61c874f171271f9ddc01c0ee5ef8ce9ffaf4e055
Author: Chris Craik <ccraik@google.com>
Date: Mon Dec 04 11:02:36 2023
TraceSectionMetric API additions
Bug: 301892382
Fixes: 301955938
Relnote: """
Several changes to TraceSectionMetric API:
- Add Mode.Min, Mode.Max
- Add label argument to override section name as metric label
- Added mode name to output to clarify metric meaning
- Changed default to sum, as most usage of this metric is for repeated events
Be aware of this changes in CI usage, as it may create discontinuities
or break parsing."""
Test: TraceSectionMetricTest
Test: ./gradlew bench:b-m:cC
Change-Id: Ic1e821511d80afb2927b3cb1095336de85e82ba1
M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/SmallListStartupBenchmark.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialPerfettoSdkBenchmark.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialStartupPerfettoSdkBenchmark.kt
M testutils/testutils-macrobenchmark/src/main/java/androidx/testutils/MacrobenchUtils.kt
https://android-review.googlesource.com/2853596
Branch: androidx-main
commit 61c874f171271f9ddc01c0ee5ef8ce9ffaf4e055
Author: Chris Craik <ccraik@google.com>
Date: Mon Dec 04 11:02:36 2023
TraceSectionMetric API additions
Bug: 301892382
Fixes: 301955938
Relnote: """
Several changes to TraceSectionMetric API:
- Add Mode.Min, Mode.Max
- Add label argument to override section name as metric label
- Added mode name to output to clarify metric meaning
- Changed default to sum, as most usage of this metric is for repeated events
Be aware of this changes in CI usage, as it may create discontinuities
or break parsing."""
Test: TraceSectionMetricTest
Test: ./gradlew bench:b-m:cC
Change-Id: Ic1e821511d80afb2927b3cb1095336de85e82ba1
M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/SmallListStartupBenchmark.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialPerfettoSdkBenchmark.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialStartupPerfettoSdkBenchmark.kt
M testutils/testutils-macrobenchmark/src/main/java/androidx/testutils/MacrobenchUtils.kt
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha01
Description
In addition to
Mode.First
andMode.Sum
, could we addMode.Max
similarly as with memory metric?This way I could find for example the longest
onDraw
section to be able to figure out where to dive further