adb devices requires adb kill-server following adb reboot [302212871]

Fixed

Bug

Status Update

No update yet.

Description

ju...@sonos.com

created issue #1

Sep 27, 2023 03:00AM

Pretty much what the title says. Any time I run adb reboot, adb devices returns an empty list. Running adb kill-server, followed by adb devices returns a non-empty list after running adb reboot. Same behavior is observed after running adb root when root is not already acquired. This is unfortunately very cumbersome, as I am working on a project that requires me to run adb reboot quite frequently. Please see below for example console output (device identifiers have been scrubbed).

$ adb --version
Android Debug Bridge version 1.0.41
Version 34.0.4-10411341
Installed as /usr/local/android/sdk-linux_x86/platform-tools/adb
Running on Linux 6.2.0-33-generic (x86_64)
$ adb devices
List of devices attached
<scrubbed> device

$ adb reboot
$ adb devices
List of devices attached

$ adb kill-server
$ adb devices
* daemon not running; starting now at tcp:5037
* daemon started successfully
List of devices attached
<scrubbed> device

For what it's worth, this is impacting a few of my co-workers, whom all have similar hardware / build environments.

Any information / debugging suggestions would be greatly appreciated. Thanks in advance.

Comments

sh...@google.com <sh...@google.com> #2Sep 27, 2023 05:51AM

Accepted by sh...@google.com.

I also have the same issue so it seems to be a real problem.

en...@google.com <en...@google.com> #3Sep 27, 2023 03:48PM

Dup here:

http://code.google.com/p/android/issues/detail?id=27959&can=1&q=fixed%20position&colspec=ID%20Type%20Status%20Owner%20Summary%20Stars

Though it's a bit more detailed with the minimum necessary to reproduce.

da...@sonos.com <da...@sonos.com> #4Sep 27, 2023 04:12PM

why is this marked has Obsolete? this is still a bug that is happening and its difficult to fix.
for all who are looking for a solution use this:

http://stackoverflow.com/questions/16200972/android-css-positionfixed-after-a-device-rotate

ju...@sonos.com <ju...@sonos.com> #5Sep 27, 2023 07:03PM

I've tested the fix proposed above and can confirm it does indeed resolve the unexpected behavior described in my original comment.

ju...@sonos.com <ju...@sonos.com> #6Sep 27, 2023 07:04PM

Would be great to see the proposed solution incorporated into Google's adb source in the future!

sh...@google.com <sh...@google.com> #7Sep 29, 2023 10:46AM

Marked as fixed.

Please stay tuned for an upcoming 34.0.5 platform tools release that will include the proposed resolution (

https://android.googlesource.com/platform/packages/modules/adb/+/7f469838d2d4abd01c6e904db2fece7fc17d75b9%5E%21/)

da...@sonos.com <da...@sonos.com> #8Sep 29, 2023 01:59PM

Thanks for the fix! This is great news.

The fix from 7f469838d2d4abd01c6e904db2fece7fc17d75b9%5E%21 will work, but I do worry about it checking that type is explicitly 0. It can still potentially lead to an infinite loop should some device contain a descriptor with a non-zero type and a zero length. While this fixes my problem, I'd still be weary of leaving this potential infinite loop in.

Thanks again

en...@google.com <en...@google.com> #9Sep 29, 2023 02:04PM

Status: Assigned (reopened)

yeah, i missed that change from ps1 to ps2. i think we should change that back.

sh...@google.com <sh...@google.com> #10Sep 29, 2023 04:06PM

I intentionally left that part in, since this is the exact scenario you are encountering (and we're relying on problem reproduction in the field). However if the consensus is to cover it more broadly (even for unknown situations), that's fine.

en...@google.com <en...@google.com> #11Sep 29, 2023 04:29PM

a zero-length descriptor will always cause this code to go into an infinite loop (because we only handle one type, and that's above this code --- if we could handle the type, we've already done so). it's never going to be useful for the adb server to hang if something's reporting a bad descriptor, so we should always break.

sh...@google.com <sh...@google.com> Oct 3, 2023 05:20AM

Marked as fixed.

ne...@gmail.com <ne...@gmail.com> #12Mar 9, 2024 12:36AM

Buenas tardes

aa...@gmail.com <aa...@gmail.com> #13Jun 19, 2024 09:01AM

Good

si...@gmail.com <si...@gmail.com> #14Jan 25, 2025 03:20PM

ShareThis

hu...@gmail.com <hu...@gmail.com> #15Jan 30, 2025 04:38PM

Marked as fixed

ja...@gmail.com <ja...@gmail.com> #16Feb 9, 2025 12:41AM

fixed