Fixed

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

Sep 27, 2023 09:19PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from transition/transition/lint-baseline.xml and address the associated issues before your next stable release.

1 instance(s) of `RestrictedApiAndroidX`

PathParser.createPathFromPathData can only be called from within the same library (androidx.core:core)

Found in src/main/java/androidx/transition/PatternPathMotion.java at line 0:
```
        Path pattern = PathParser.createPathFromPathData(pathData);
                                  ~~~~~~~~~~~~~~~~~~~~~~
```

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

This is similar to this bug report as well: https://issuetracker.google.com/issues/172590946

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

Hi Yinglei, re-assigning back to you as you're currently working on exactly this for Snackbars.

ya...@google.com <ya...@google.com> #4Sep 28, 2023 02:33AM

Reassigned to ti...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 506fcdecc2dc257b58c574006d70ea9ce6f0bfda
Author: Yinglei Wang <yingleiw@google.com>
Date: Fri Feb 26 15:58:00 2021

add semantics liveRegion and apply it to snackbar

Snackbar should be marked as live region for accessibility. When talkback
is on, the snackbar is announced when it appears. Also added dismiss
action for the snackbar.

Note that since we are not merging up the tree for subtree change
events, we don't need to do extra work for live region. From android
documentation and discussion with Phil, the throttling delay is fine for
accessibility events from live region.

Relnote: "LiveRegion accessibility API is added.
If node is marked as a live region, the accessibility services
will automatically notify the user about its changes"

Fix:

b/153644625

b/172590946

b/182834687

Test: tested manully with talkback on. Unit tests added.

Change-Id: Idcf6f425b12b005e59ad77fe7430e466132ea87c

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SnackbarHostTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
M compose/ui/ui/api/1.0.0-beta04.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta04.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta04.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1580798

ti...@google.com <ti...@google.com> #5Sep 28, 2023 07:05PM

Reassigned to ya...@google.com.

Doris, can I make this PathParser public? I see your comment from 5 years ago that this should be public.

Yes. Please make PathParser class and createPathFromPathData method public. Please also make the methods that are currently public in that class package private if possible, so that we can minimize the public API surface. Thank you, Yuichi.

ap...@google.com <ap...@google.com> #6Oct 10, 2023 04:25AM

Project: platform/frameworks/support
Branch: androidx-main

commit 910e6e724f9ab568c2c41fcfa2770b72ab7f164b
Author: Yuichi Araki <yaraki@google.com>
Date: Fri Sep 29 13:56:56 2023

Fix RestrictedApiAndroidX in transition

Relnote: "Make PathParser public. The class can create a Path instance from SVG path strings."
Bug: 302376846
Test: ./gradlew :transition:transition:lintDebug
Change-Id: Ic7af2e7ea294ed43e8ebcf41852d2c1618816655

M core/core-animation/build.gradle
M core/core/api/api_lint.ignore
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/graphics/PathParser.java
M fragment/fragment-testing/build.gradle
M transition/transition/build.gradle
M transition/transition/lint-baseline.xml
M vectordrawable/vectordrawable-animated/build.gradle
M vectordrawable/vectordrawable/build.gradle
M vectordrawable/vectordrawable/src/main/java/androidx/vectordrawable/graphics/drawable/VectorDrawableCompat.java

https://android-review.googlesource.com/2769138

ya...@google.com <ya...@google.com> Oct 10, 2023 04:26AM

Marked as fixed.

pr...@google.com <pr...@google.com> #7Oct 18, 2023 08:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core:1.13.0-alpha01

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment-testing:1.7.0-alpha07
androidx.transition:transition:1.5.0-alpha05

IssueTracker

Fix 1 lint baseline suppression(s) of RestrictedApiAndroidX

Status Update

Description

1 instance(s) of `RestrictedApiAndroidX`

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ya...@google.com <ya...@google.com> #4Sep 28, 2023 02:33AM

ti...@google.com <ti...@google.com> #5Sep 28, 2023 07:05PM

ap...@google.com <ap...@google.com> #6Oct 10, 2023 04:25AM

ya...@google.com <ya...@google.com> Oct 10, 2023 04:26AM

pr...@google.com <pr...@google.com> #7Oct 18, 2023 08:41PM

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

Issue 302376846

Description

1 instance(s) of RestrictedApiAndroidX

Issue summary

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ya...@google.com <ya...@google.com> #4Sep 28, 2023 02:33AM

ti...@google.com <ti...@google.com> #5Sep 28, 2023 07:05PM

ap...@google.com <ap...@google.com> #6Oct 10, 2023 04:25AM

ya...@google.com <ya...@google.com> Oct 10, 2023 04:26AM

pr...@google.com <pr...@google.com> #7Oct 18, 2023 08:41PM

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

Add comment

Issue metadata

1 instance(s) of `RestrictedApiAndroidX`