Fixed

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

Sep 27, 2023 09:19PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from transition/transition/lint-baseline.xml and address the associated issues before your next stable release.

1 instance(s) of `RestrictedApiAndroidX`

PathParser.createPathFromPathData can only be called from within the same library (androidx.core:core)

Found in src/main/java/androidx/transition/PatternPathMotion.java at line 0:
```
        Path pattern = PathParser.createPathFromPathData(pathData);
                                  ~~~~~~~~~~~~~~~~~~~~~~
```

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

This is actually the intended behavior, the text overload was only intended for the simplest use case. Anything else requires the lambda API by design. Having discussed this further, the distinction between overloads is confusing though, and there isn't much value in just providing a string overload. As a result we plan to remove the string overload for Button, see how that goes, and then evaluate our overall 'string overload strategy' across other components.

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e386f97dd769da18d9f3103958714e43d797219f
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Jan 31 17:32:33 2020

Monthly button refactoring

- Removes string overload for Button
- Replaces ButtonStyle with distinct functions, the following is the
migration strategy:

ContainedButtonStyle -> Button
OutlinedButtonStyle -> OutlinedButton
TextButtonStyle -> TextButton
Custom ButtonStyle -> Any / which ever is most semantically related

Now that each function takes the same parameters, and there are no
overloads, there is no more large separation between layers - extra
customization is just a matter of supplying more parameters, instead of
needing to find overloads / copy and paste parameters from high level
styles into the base ButtonStyle.

Also adds sample for Modifiers so the samples won't break when API
changes like this are made.

Bug:

b/146478620

Bug:

b/146482131

Bug:

b/146346551

Test: ButtonTest
Change-Id: If63ab32bd3f12050a2d2f4b8c0cb044bc7144a6b
Relnote: "Replaced ButtonStyle with distinct functions and removed text (string) overload. See updated samples for usage information."

M compose/compose-runtime/integration-tests/samples/src/main/java/androidx/compose/samples/EffectSamples.kt
M compose/compose-runtime/integration-tests/samples/src/main/java/androidx/compose/samples/ModelSamples.kt
M compose/compose-runtime/integration-tests/samples/src/main/java/androidx/compose/samples/RecomposeSamples.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/ViewInCompose.kt
M ui/ui-core/integration-tests/samples/build.gradle
A ui/ui-core/integration-tests/samples/src/main/java/androidx/ui/core/samples/ModifierSamples.kt
M ui/ui-core/src/main/java/androidx/ui/core/Modifier.kt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/SemanticsL1.kt
M ui/ui-material/api/0.1.0-dev05.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev05.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev05.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ButtonActivity.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/CustomShapeActivity.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/TabActivity.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/RallyAlertDialog.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/RallyCards.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/AlertDialogSample.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/ButtonSamples.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/DrawerSamples.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/SnackbarSample.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Button.kt
M ui/ui-material/src/main/java/androidx/ui/material/Snackbar.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertExistsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CustomActivityTest.kt

https://android-review.googlesource.com/1222411

ya...@google.com <ya...@google.com> #4Sep 28, 2023 02:33AM

Reassigned to ti...@google.com.

Doris, can I make this PathParser public? I see your comment from 5 years ago that this should be public.

ti...@google.com <ti...@google.com> #5Sep 28, 2023 07:05PM

Reassigned to ya...@google.com.

Doris, can I make this PathParser public? I see your comment from 5 years ago that this should be public.

Yes. Please make PathParser class and createPathFromPathData method public. Please also make the methods that are currently public in that class package private if possible, so that we can minimize the public API surface. Thank you, Yuichi.

ap...@google.com <ap...@google.com> #6Oct 10, 2023 04:25AM

Project: platform/frameworks/support
Branch: androidx-main

commit 910e6e724f9ab568c2c41fcfa2770b72ab7f164b
Author: Yuichi Araki <yaraki@google.com>
Date: Fri Sep 29 13:56:56 2023

Fix RestrictedApiAndroidX in transition

Relnote: "Make PathParser public. The class can create a Path instance from SVG path strings."
Bug: 302376846
Test: ./gradlew :transition:transition:lintDebug
Change-Id: Ic7af2e7ea294ed43e8ebcf41852d2c1618816655

M core/core-animation/build.gradle
M core/core/api/api_lint.ignore
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/graphics/PathParser.java
M fragment/fragment-testing/build.gradle
M transition/transition/build.gradle
M transition/transition/lint-baseline.xml
M vectordrawable/vectordrawable-animated/build.gradle
M vectordrawable/vectordrawable/build.gradle
M vectordrawable/vectordrawable/src/main/java/androidx/vectordrawable/graphics/drawable/VectorDrawableCompat.java

https://android-review.googlesource.com/2769138

ya...@google.com <ya...@google.com> Oct 10, 2023 04:26AM

Marked as fixed.

pr...@google.com <pr...@google.com> #7Oct 18, 2023 08:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core:1.13.0-alpha01

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment-testing:1.7.0-alpha07
androidx.transition:transition:1.5.0-alpha05

IssueTracker

Fix 1 lint baseline suppression(s) of RestrictedApiAndroidX

Status Update

Description

1 instance(s) of `RestrictedApiAndroidX`

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ya...@google.com <ya...@google.com> #4Sep 28, 2023 02:33AM

ti...@google.com <ti...@google.com> #5Sep 28, 2023 07:05PM

ap...@google.com <ap...@google.com> #6Oct 10, 2023 04:25AM

ya...@google.com <ya...@google.com> Oct 10, 2023 04:26AM

pr...@google.com <pr...@google.com> #7Oct 18, 2023 08:41PM

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

Issue 302376846

Description

1 instance(s) of RestrictedApiAndroidX

Issue summary

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ya...@google.com <ya...@google.com> #4Sep 28, 2023 02:33AM

ti...@google.com <ti...@google.com> #5Sep 28, 2023 07:05PM

ap...@google.com <ap...@google.com> #6Oct 10, 2023 04:25AM

ya...@google.com <ya...@google.com> Oct 10, 2023 04:26AM

pr...@google.com <pr...@google.com> #7Oct 18, 2023 08:41PM

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

Add comment

Issue metadata

1 instance(s) of `RestrictedApiAndroidX`