Assigned
Status Update
Comments
al...@google.com <al...@google.com> #2
Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:
<transition xmlns:android="http://schemas.android.com/apk/res/android " >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="http://schemas.android.com/apk/res/android "
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
<transition xmlns:android="
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
al...@google.com <al...@google.com> #3
Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)
js...@google.com <js...@google.com>
se...@google.com <se...@google.com> #4
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 8636738860ab0da3c2b6fe3b1ab6baa35d9c6066
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Oct 23 13:24:54 2023
Fix xmodule restrict for GoogleFont
Fix: b/302377512
Test: n/a
Relnote: n/a
Change-Id: If3a223649c9bbbb07e553f784211f02ef8c76f8b
D compose/ui/ui-text-google-fonts/lint-baseline.xml
M compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
https://android-review.googlesource.com/2800220
Branch: androidx-main
commit 8636738860ab0da3c2b6fe3b1ab6baa35d9c6066
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Oct 23 13:24:54 2023
Fix xmodule restrict for GoogleFont
Fix:
Test: n/a
Relnote: n/a
Change-Id: If3a223649c9bbbb07e553f784211f02ef8c76f8b
D compose/ui/ui-text-google-fonts/lint-baseline.xml
M compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 99c933c307b058d983319046311831e1c2138ce5
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed May 15 16:23:08 2024
Introduce new public FontsContractCompat.requestFonts
- Takes Executor for both loading and callback threads
- Allows configuring returned Typeface style
Relnote: Create FontsContractCompat.requestFonts that takes executors
Test: ./gradlew :core:core:cAT
Bug: b/302377512
Change-Id: I0301600d9a3c2f5062631d59105e42ad51bb4754
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/provider/FontsContractCompatTest.java
M core/core/src/main/java/androidx/core/provider/CallbackWrapper.java
M core/core/src/main/java/androidx/core/provider/FontRequestWorker.java
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
https://android-review.googlesource.com/3090665
Branch: androidx-main
commit 99c933c307b058d983319046311831e1c2138ce5
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed May 15 16:23:08 2024
Introduce new public FontsContractCompat.requestFonts
- Takes Executor for both loading and callback threads
- Allows configuring returned Typeface style
Relnote: Create FontsContractCompat.requestFonts that takes executors
Test: ./gradlew :core:core:cAT
Bug:
Change-Id: I0301600d9a3c2f5062631d59105e42ad51bb4754
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/provider/FontsContractCompatTest.java
M core/core/src/main/java/androidx/core/provider/CallbackWrapper.java
M core/core/src/main/java/androidx/core/provider/FontRequestWorker.java
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
Description
The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from
compose/ui/ui-text-google-fonts/lint-baseline.xml
and address the associated issues before your next stable release.1 instance(s) of
RestrictedApiAndroidX
FontsContractCompat.requestFont can only be called from within the same library (androidx.core:core)
Found in
src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt
at line 0: