Assigned
Status Update
Comments
al...@google.com <al...@google.com> #2
IMPORTANT! Please note that if you released your library to stable with these calls, the APIs must maintain binary compatibility moving forward.
That means the restricted APIs need to be made public or @RestrictTo(LIBRARY_GROUP_PREFIX) (e.g. effectively public for the purposes of compatibility).
You CANNOT simply remove the call to the restricted API.
That means the restricted APIs need to be made public or @RestrictTo(LIBRARY_GROUP_PREFIX) (e.g. effectively public for the purposes of compatibility).
You CANNOT simply remove the call to the restricted API.
al...@google.com <al...@google.com> #3
Sorry, additional point of clarification. These bugs have been filed against the call sites, but the issue really applies to both the restricted API and the call site.
For the call site: the call may be safely removed, however if the call went out in a stable release then that release will crash if the restricted API is removed.
If the restricted API should be maintained to ensure binary compatibility with your library, please forward this issue to the component for the restricted API and continue reading.
For the restricted API: this bug was filed because your API was used outside of your library group. The API must now be tracked for binary compatibility. You may make the API public or LIBRARY_GROUP_PREFIX visibility.
For the call site: the call may be safely removed, however if the call went out in a stable release then that release will crash if the restricted API is removed.
If the restricted API should be maintained to ensure binary compatibility with your library, please forward this issue to the component for the restricted API and continue reading.
For the restricted API: this bug was filed because your API was used outside of your library group. The API must now be tracked for binary compatibility. You may make the API public or LIBRARY_GROUP_PREFIX visibility.
js...@google.com <js...@google.com>
se...@google.com <se...@google.com> #4
Ah thank you. Odd that didn't blow up earlier.
Promoting this API to LIBRARY_GROUP_PREFIX it's already been launched.
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 8636738860ab0da3c2b6fe3b1ab6baa35d9c6066
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Oct 23 13:24:54 2023
Fix xmodule restrict for GoogleFont
Fix: b/302377512
Test: n/a
Relnote: n/a
Change-Id: If3a223649c9bbbb07e553f784211f02ef8c76f8b
D compose/ui/ui-text-google-fonts/lint-baseline.xml
M compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
https://android-review.googlesource.com/2800220
Branch: androidx-main
commit 8636738860ab0da3c2b6fe3b1ab6baa35d9c6066
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Oct 23 13:24:54 2023
Fix xmodule restrict for GoogleFont
Fix:
Test: n/a
Relnote: n/a
Change-Id: If3a223649c9bbbb07e553f784211f02ef8c76f8b
D compose/ui/ui-text-google-fonts/lint-baseline.xml
M compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 99c933c307b058d983319046311831e1c2138ce5
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed May 15 16:23:08 2024
Introduce new public FontsContractCompat.requestFonts
- Takes Executor for both loading and callback threads
- Allows configuring returned Typeface style
Relnote: Create FontsContractCompat.requestFonts that takes executors
Test: ./gradlew :core:core:cAT
Bug: b/302377512
Change-Id: I0301600d9a3c2f5062631d59105e42ad51bb4754
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/provider/FontsContractCompatTest.java
M core/core/src/main/java/androidx/core/provider/CallbackWrapper.java
M core/core/src/main/java/androidx/core/provider/FontRequestWorker.java
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
https://android-review.googlesource.com/3090665
Branch: androidx-main
commit 99c933c307b058d983319046311831e1c2138ce5
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed May 15 16:23:08 2024
Introduce new public FontsContractCompat.requestFonts
- Takes Executor for both loading and callback threads
- Allows configuring returned Typeface style
Relnote: Create FontsContractCompat.requestFonts that takes executors
Test: ./gradlew :core:core:cAT
Bug:
Change-Id: I0301600d9a3c2f5062631d59105e42ad51bb4754
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/provider/FontsContractCompatTest.java
M core/core/src/main/java/androidx/core/provider/CallbackWrapper.java
M core/core/src/main/java/androidx/core/provider/FontRequestWorker.java
M core/core/src/main/java/androidx/core/provider/FontsContractCompat.java
Description
The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from
compose/ui/ui-text-google-fonts/lint-baseline.xml
and address the associated issues before your next stable release.1 instance(s) of
RestrictedApiAndroidX
FontsContractCompat.requestFont can only be called from within the same library (androidx.core:core)
Found in
src/main/java/androidx/compose/ui/text/googlefonts/GoogleFont.kt
at line 0: