Fixed

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

Sep 27, 2023 09:28PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from window/window/lint-baseline.xml and address the associated issues before your next stable release.

5 instance(s) of `RestrictedApiAndroidX`

ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    primaryActivityStack.token,
                                         ~~~~~
```
ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    primaryActivityStack.token,
                                         ~~~~~
```
ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    secondaryActivityStack.token,
                                           ~~~~~
```
ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    secondaryActivityStack.token,
                                           ~~~~~
```
WindowExtensions.VENDOR_API_LEVEL_2 can only be accessed from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingCompat.kt at line 0:
```
    if (ExtensionsUtil.safeVendorApiLevel < VENDOR_API_LEVEL_2) {
                                            ~~~~~~~~~~~~~~~~~~
```

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

Attached reproducing video of an app using calculateWindowSizeClass and LocalConfiguration:

On the second time resizing to be 50%/50% from smaller, the displayed configuration is incorrect.

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

When resizing the activity in multi-window mode under those conditions, there are cases where:

the Activity is not recreated Activity.onConfigurationChanged is not called View.onConfigurationChanged is not called

Is this just for 33 / is there a framework bug filed? The amount of broken things in configuration land we already had to workaround in Compose is a bit untenable. It seems like we are missing a lot of test coverage in the platform to avoid these issues hitting us in the future

ch...@google.com <ch...@google.com> Sep 28, 2023 01:03PM

Reassigned to ch...@google.com.

di...@google.com <di...@google.com> Sep 29, 2023 02:32PM

Marked as fixed, reassigned to di...@google.com.

ap...@google.com <ap...@google.com> #4Sep 29, 2023 02:33PM

In any case this seems like more ammunition for us to push more strongly on 'pure-compose apps should always opt out of configuration changes'

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:42PM

Yes, API 33 introduced this behavior, (internal) platform bug is here: b/247013643

pa...@gmail.com <pa...@gmail.com> #6Feb 27, 2024 06:41AM

I was incorrect, this is also reproducible on API 32 as well. Not reproducible on API 31.

pr...@google.com <pr...@google.com> #7Aug 13, 2024 06:58PM

Adam/Louis, how do we want to handle this one? Is there someone on platform who should take this, or since API 32 is already out in the wild maybe this should go to devrel to push more strongly on 'pure-compose apps should always opt out of configuration changes'.

IssueTracker

Fix 5 lint baseline suppression(s) of RestrictedApiAndroidX

Status Update

Description

5 instance(s) of `RestrictedApiAndroidX`

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ch...@google.com <ch...@google.com> Sep 28, 2023 01:03PM

di...@google.com <di...@google.com> Sep 29, 2023 02:32PM

ap...@google.com <ap...@google.com> #4Sep 29, 2023 02:33PM

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:42PM

pa...@gmail.com <pa...@gmail.com> #6Feb 27, 2024 06:41AM

pr...@google.com <pr...@google.com> #7Aug 13, 2024 06:58PM

Issue 302380585

Description

5 instance(s) of RestrictedApiAndroidX

Issue summary

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ch...@google.com <ch...@google.com> Sep 28, 2023 01:03PM

di...@google.com <di...@google.com> Sep 29, 2023 02:32PM

ap...@google.com <ap...@google.com> #4Sep 29, 2023 02:33PM

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:42PM

pa...@gmail.com <pa...@gmail.com> #6Feb 27, 2024 06:41AM

pr...@google.com <pr...@google.com> #7Aug 13, 2024 06:58PM

Add comment

Issue metadata

5 instance(s) of `RestrictedApiAndroidX`