Fixed
Status Update
Comments
al...@google.com <al...@google.com> #2
IMPORTANT! Please note that if you released your library to stable with these calls, the APIs must maintain binary compatibility moving forward.
That means the restricted APIs need to be made public or @RestrictTo(LIBRARY_GROUP_PREFIX) (e.g. effectively public for the purposes of compatibility).
You CANNOT simply remove the call to the restricted API.
That means the restricted APIs need to be made public or @RestrictTo(LIBRARY_GROUP_PREFIX) (e.g. effectively public for the purposes of compatibility).
You CANNOT simply remove the call to the restricted API.
al...@google.com <al...@google.com> #3
Sorry, additional point of clarification. These bugs have been filed against the call sites, but the issue really applies to both the restricted API and the call site.
For the call site: the call may be safely removed, however if the call went out in a stable release then that release will crash if the restricted API is removed.
If the restricted API should be maintained to ensure binary compatibility with your library, please forward this issue to the component for the restricted API and continue reading.
For the restricted API: this bug was filed because your API was used outside of your library group. The API must now be tracked for binary compatibility. You may make the API public or LIBRARY_GROUP_PREFIX visibility.
For the call site: the call may be safely removed, however if the call went out in a stable release then that release will crash if the restricted API is removed.
If the restricted API should be maintained to ensure binary compatibility with your library, please forward this issue to the component for the restricted API and continue reading.
For the restricted API: this bug was filed because your API was used outside of your library group. The API must now be tracked for binary compatibility. You may make the API public or LIBRARY_GROUP_PREFIX visibility.
ch...@google.com <ch...@google.com>
di...@google.com <di...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit a07fd4daffa8b3e387fe9a72fab7aff38fc0bf7e
Author: Diego Vela <diegovela@google.com>
Date: Wed Sep 27 22:17:56 2023
Pin dependencies for window.
Pin dependencies from window on extensions.
Fix pending lint errors. Some lint errors went unnoticed and we need to
fix them before releasing.
Relnote: Remove unstable APIs.
Bug: 302380585
Test: ./gradlew window:window:cAT
Merged-In: Ibc534a8ba5f81f0fdcde569335a581e605d1c69e
Change-Id: Ibc534a8ba5f81f0fdcde569335a581e605d1c69e
M libraryversions.toml
A window/window-core/api/1.2.0-beta04.txt
A window/window-core/api/res-1.2.0-beta04.txt
A window/window-core/api/restricted_1.2.0-beta04.txt
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitActivityBase.java
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitAttributesToggleMainActivity.kt
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitAttributesTogglePrimaryActivity.kt
M window/window-demos/demo/src/main/res/layout/activity_split_attributes_toggle_primary_activity.xml
A window/window-java/api/1.2.0-beta04.txt
A window/window-java/api/res-1.2.0-beta04.txt
A window/window-java/api/restricted_1.2.0-beta04.txt
A window/window-rxjava2/api/1.2.0-beta04.txt
A window/window-rxjava2/api/res-1.2.0-beta04.txt
A window/window-rxjava2/api/restricted_1.2.0-beta04.txt
A window/window-rxjava3/api/1.2.0-beta04.txt
A window/window-rxjava3/api/res-1.2.0-beta04.txt
A window/window-rxjava3/api/restricted_1.2.0-beta04.txt
A window/window-testing/api/1.2.0-beta04.txt
A window/window-testing/api/res-1.2.0-beta04.txt
A window/window-testing/api/restricted_1.2.0-beta04.txt
M window/window-testing/src/main/java/androidx/window/testing/embedding/ActivityStackTesting.kt
M window/window-testing/src/main/java/androidx/window/testing/embedding/StubEmbeddingBackend.kt
M window/window-testing/src/test/java/androidx/window/testing/embedding/ActivityStackTestingJavaTest.java
M window/window-testing/src/test/java/androidx/window/testing/embedding/ActivityStackTestingTest.kt
M window/window-testing/src/test/java/androidx/window/testing/embedding/TestSplitInfo.kt
A window/window/api/1.2.0-beta04.txt
A window/window/api/current.ignore
M window/window/api/current.txt
A window/window/api/res-1.2.0-beta04.txt
A window/window/api/restricted_1.2.0-beta04.txt
A window/window/api/restricted_current.ignore
M window/window/api/restricted_current.txt
M window/window/build.gradle
D window/window/lint-baseline.xml
D window/window/samples/src/main/java/androidx.window.samples.embedding/FinishActivityStacksSamples.kt
M window/window/src/androidTest/java/androidx/window/embedding/EmbeddingAdapterTest.kt
M window/window/src/main/java/androidx/window/embedding/ActivityEmbeddingController.kt
D window/window/src/main/java/androidx/window/embedding/ActivityEmbeddingOptions.kt
M window/window/src/main/java/androidx/window/embedding/ActivityStack.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingAdapter.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingBackend.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingCompat.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingInterfaceCompat.kt
M window/window/src/main/java/androidx/window/embedding/ExtensionEmbeddingBackend.kt
M window/window/src/test/java/androidx/window/embedding/ActivityEmbeddingControllerTest.kt
D window/window/src/test/java/androidx/window/embedding/ActivityEmbeddingOptionsTest.kt
M window/window/src/test/java/androidx/window/embedding/ActivityStackTest.kt
M window/window/src/test/java/androidx/window/embedding/RequiresWindowSdkExtensionTests.kt
M window/window/src/test/java/androidx/window/embedding/SplitControllerTest.kt
M window/window/src/test/java/androidx/window/embedding/SplitInfoTest.kt
https://android-review.googlesource.com/2766089
Branch: androidx-main
commit a07fd4daffa8b3e387fe9a72fab7aff38fc0bf7e
Author: Diego Vela <diegovela@google.com>
Date: Wed Sep 27 22:17:56 2023
Pin dependencies for window.
Pin dependencies from window on extensions.
Fix pending lint errors. Some lint errors went unnoticed and we need to
fix them before releasing.
Relnote: Remove unstable APIs.
Bug: 302380585
Test: ./gradlew window:window:cAT
Merged-In: Ibc534a8ba5f81f0fdcde569335a581e605d1c69e
Change-Id: Ibc534a8ba5f81f0fdcde569335a581e605d1c69e
M libraryversions.toml
A window/window-core/api/1.2.0-beta04.txt
A window/window-core/api/res-1.2.0-beta04.txt
A window/window-core/api/restricted_1.2.0-beta04.txt
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitActivityBase.java
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitAttributesToggleMainActivity.kt
M window/window-demos/demo/src/main/java/androidx/window/demo/embedding/SplitAttributesTogglePrimaryActivity.kt
M window/window-demos/demo/src/main/res/layout/activity_split_attributes_toggle_primary_activity.xml
A window/window-java/api/1.2.0-beta04.txt
A window/window-java/api/res-1.2.0-beta04.txt
A window/window-java/api/restricted_1.2.0-beta04.txt
A window/window-rxjava2/api/1.2.0-beta04.txt
A window/window-rxjava2/api/res-1.2.0-beta04.txt
A window/window-rxjava2/api/restricted_1.2.0-beta04.txt
A window/window-rxjava3/api/1.2.0-beta04.txt
A window/window-rxjava3/api/res-1.2.0-beta04.txt
A window/window-rxjava3/api/restricted_1.2.0-beta04.txt
A window/window-testing/api/1.2.0-beta04.txt
A window/window-testing/api/res-1.2.0-beta04.txt
A window/window-testing/api/restricted_1.2.0-beta04.txt
M window/window-testing/src/main/java/androidx/window/testing/embedding/ActivityStackTesting.kt
M window/window-testing/src/main/java/androidx/window/testing/embedding/StubEmbeddingBackend.kt
M window/window-testing/src/test/java/androidx/window/testing/embedding/ActivityStackTestingJavaTest.java
M window/window-testing/src/test/java/androidx/window/testing/embedding/ActivityStackTestingTest.kt
M window/window-testing/src/test/java/androidx/window/testing/embedding/TestSplitInfo.kt
A window/window/api/1.2.0-beta04.txt
A window/window/api/current.ignore
M window/window/api/current.txt
A window/window/api/res-1.2.0-beta04.txt
A window/window/api/restricted_1.2.0-beta04.txt
A window/window/api/restricted_current.ignore
M window/window/api/restricted_current.txt
M window/window/build.gradle
D window/window/lint-baseline.xml
D window/window/samples/src/main/java/androidx.window.samples.embedding/FinishActivityStacksSamples.kt
M window/window/src/androidTest/java/androidx/window/embedding/EmbeddingAdapterTest.kt
M window/window/src/main/java/androidx/window/embedding/ActivityEmbeddingController.kt
D window/window/src/main/java/androidx/window/embedding/ActivityEmbeddingOptions.kt
M window/window/src/main/java/androidx/window/embedding/ActivityStack.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingAdapter.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingBackend.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingCompat.kt
M window/window/src/main/java/androidx/window/embedding/EmbeddingInterfaceCompat.kt
M window/window/src/main/java/androidx/window/embedding/ExtensionEmbeddingBackend.kt
M window/window/src/test/java/androidx/window/embedding/ActivityEmbeddingControllerTest.kt
D window/window/src/test/java/androidx/window/embedding/ActivityEmbeddingOptionsTest.kt
M window/window/src/test/java/androidx/window/embedding/ActivityStackTest.kt
M window/window/src/test/java/androidx/window/embedding/RequiresWindowSdkExtensionTests.kt
M window/window/src/test/java/androidx/window/embedding/SplitControllerTest.kt
M window/window/src/test/java/androidx/window/embedding/SplitInfoTest.kt
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.window:window:1.2.0-beta04
androidx.window:window-core:1.2.0-beta04
androidx.window:window-java:1.2.0-beta04
androidx.window:window-rxjava2:1.2.0-beta04
androidx.window:window-rxjava3:1.2.0-beta04
androidx.window:window-testing:1.2.0-beta04
pa...@gmail.com <pa...@gmail.com> #6
Think my phone ain't got to spyware on it
pr...@google.com <pr...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.window:window-testing:1.4.0-alpha01
Description
The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from
window/window/lint-baseline.xml
and address the associated issues before your next stable release.5 instance(s) of
RestrictedApiAndroidX
ActivityStack.getToken can only be called from within the same library group (referenced groupId=
androidx.window.extensions
from groupId=androidx.window
)Found in
src/main/java/androidx/window/embedding/EmbeddingAdapter.kt
at line 0:ActivityStack.getToken can only be called from within the same library group (referenced groupId=
androidx.window.extensions
from groupId=androidx.window
)Found in
src/main/java/androidx/window/embedding/EmbeddingAdapter.kt
at line 0:ActivityStack.getToken can only be called from within the same library group (referenced groupId=
androidx.window.extensions
from groupId=androidx.window
)Found in
src/main/java/androidx/window/embedding/EmbeddingAdapter.kt
at line 0:ActivityStack.getToken can only be called from within the same library group (referenced groupId=
androidx.window.extensions
from groupId=androidx.window
)Found in
src/main/java/androidx/window/embedding/EmbeddingAdapter.kt
at line 0:WindowExtensions.VENDOR_API_LEVEL_2 can only be accessed from within the same library group (referenced groupId=
androidx.window.extensions
from groupId=androidx.window
)Found in
src/main/java/androidx/window/embedding/EmbeddingCompat.kt
at line 0: