Fixed

Process

Status Update

No update yet.

Description

al...@google.com

created issue #1

Sep 27, 2023 09:28PM

The following lint check is baseline suppressed in your project. Please remove all instances of this suppression from window/window/lint-baseline.xml and address the associated issues before your next stable release.

5 instance(s) of `RestrictedApiAndroidX`

ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    primaryActivityStack.token,
                                         ~~~~~
```
ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    primaryActivityStack.token,
                                         ~~~~~
```
ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    secondaryActivityStack.token,
                                           ~~~~~
```
ActivityStack.getToken can only be called from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingAdapter.kt at line 0:
```
                    secondaryActivityStack.token,
                                           ~~~~~
```
WindowExtensions.VENDOR_API_LEVEL_2 can only be accessed from within the same library group (referenced groupId=androidx.window.extensions from groupId=androidx.window)

Found in src/main/java/androidx/window/embedding/EmbeddingCompat.kt at line 0:
```
    if (ExtensionsUtil.safeVendorApiLevel < VENDOR_API_LEVEL_2) {
                                            ~~~~~~~~~~~~~~~~~~
```

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

Could be related to the changes you've made in FixedFragmentStateAdapter. Could you share the code, I can have a quick look.

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

> Could be related to the changes you've made in FixedFragmentStateAdapter. Could you share the code, I can have a quick look.

Sorry, but I believe that is not a culprit. I just added a single line of code to avoid BadParcelableException.

https://issuetracker.google.com/issues/132840199

```
@Override
public final void restoreState(@NonNull Parcelable savedState) {
if (!mSavedStates.isEmpty() || !mFragments.isEmpty()) {
throw new IllegalStateException(
"Expected the adapter to be 'fresh' while restoring state.");
}

Bundle bundle = (Bundle) savedState;
bundle.setClassLoader(getClass().getClassLoader()); // <-- ADDED THIS LINE

for (String key : bundle.keySet()) {
...
}
```

ch...@google.com <ch...@google.com> Sep 28, 2023 01:03PM

Reassigned to ch...@google.com.

di...@google.com <di...@google.com> Sep 29, 2023 02:32PM

Marked as fixed, reassigned to di...@google.com.

ap...@google.com <ap...@google.com> #4Sep 29, 2023 02:33PM

I investigated the issue and turned out the part of the scenario which causes the problem;

1. RecyclerView.recycleViewHolderInternal()
2. hodler.doesTransientStatePreventRecycling() retuns true
3. FragmentStateAdapter.onFailedToRecycleView() -> onViewRecycled() -> removeFragment()
4. onFailedToRecycleView() retuns false, it means the ViewHolder is not recycled yet.
5. Soon after, FragmentStateAdapter.onViewAttachedToWindow() -> placeFragmentInViewHolder() -> IllegalStateException("Design assumption violated.")

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:42PM

Hi! I have successfully created a demo project which can reproduce this issue. Please check the following repo and I hope it helps to resolve the issue.

https://github.com/h6ah4i/FragmentStateAdapterOnFailedToRecyclerViewFailure

pa...@gmail.com <pa...@gmail.com> #6Feb 27, 2024 06:41AM

[UPDATE]
This issue still exists on ViewPager2 v1.0.0-alpha06 with RecyclerView v1.1.0-beta01.

pr...@google.com <pr...@google.com> #7Aug 13, 2024 06:58PM

I can confirm I can repro this and will try to provide a workaround / fix soon.
Big thanks for the sample app, repro steps and research info. Super appreciated!

IssueTracker

Fix 5 lint baseline suppression(s) of RestrictedApiAndroidX

Status Update

Description

5 instance(s) of `RestrictedApiAndroidX`

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ch...@google.com <ch...@google.com> Sep 28, 2023 01:03PM

di...@google.com <di...@google.com> Sep 29, 2023 02:32PM

ap...@google.com <ap...@google.com> #4Sep 29, 2023 02:33PM

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:42PM

pa...@gmail.com <pa...@gmail.com> #6Feb 27, 2024 06:41AM

pr...@google.com <pr...@google.com> #7Aug 13, 2024 06:58PM

Issue 302380585

Description

5 instance(s) of RestrictedApiAndroidX

Issue summary

Comments

al...@google.com <al...@google.com> #2Sep 27, 2023 09:48PM

al...@google.com <al...@google.com> #3Sep 27, 2023 10:39PM

ch...@google.com <ch...@google.com> Sep 28, 2023 01:03PM

di...@google.com <di...@google.com> Sep 29, 2023 02:32PM

ap...@google.com <ap...@google.com> #4Sep 29, 2023 02:33PM

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:42PM

pa...@gmail.com <pa...@gmail.com> #6Feb 27, 2024 06:41AM

pr...@google.com <pr...@google.com> #7Aug 13, 2024 06:58PM

Add comment

Issue metadata

5 instance(s) of `RestrictedApiAndroidX`