Benchmarks - Regression found between 10870191 and 10870194 [302399827]

Fixed

Bug

Status Update

No update yet.

Description

sk...@skia-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Sep 27, 2023 11:46PM

Perf Regression (High) found, matching 4 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Tests affected:

 androidx.wear.compose.material.benchmark.PositionIndicatorBenchmark_changeFraction
 androidx.wear.compose.material.benchmark.PositionIndicatorBenchmark_changeFractionAndSizeFraction_autoHide
 androidx.wear.compose.material.benchmark.PositionIndicatorBenchmark_changeFractionAndSizeFraction_hide
 androidx.wear.compose.material.benchmark.PositionIndicatorBenchmark_firstPixel

Devices affected:

 wembley

Comments

js...@google.com <js...@google.com> #2Sep 29, 2023 06:34PM

Reassigned to mk...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

st...@google.com <st...@google.com> #3Oct 2, 2023 09:46AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

mk...@google.com <mk...@google.com> Oct 2, 2023 09:50AM

Accepted by mk...@google.com.

ap...@google.com <ap...@google.com> #4Oct 11, 2023 01:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 136cfb249a9623d712b82db6b0832ccd63e3e582
Author: mkulaha <mkulaha@google.com>
Date: Wed Oct 04 08:05:18 2023

Possible fix for performance drop in PositionIndicator. Additional microbenchmark tests were added.

We saw some performance drops in PositionIndicator, that might happen due to chained snapshotFlow, which slows down the `firstPixel` benchmark.
Extra tests were added to separately check animated and non-animated PositionIndicator
Doc with benchmark results go/position-indicator-aosp_2770702

Bug: 302399827
Test: PositionIndicatorBenchmark.kt
Relnote: "Fixed performance issues in PositionIndicator"
Change-Id: I1c6546abc834f718c9d8f11d756262d507590acc

M wear/compose/compose-material/benchmark/src/androidTest/java/androidx/wear/compose/material/benchmark/PositionIndicatorBenchmark.kt
M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/PositionIndicator.kt

https://android-review.googlesource.com/2770702

mk...@google.com <mk...@google.com> #5Oct 12, 2023 09:21AM

Marked as fixed.

Looks like the latest changes (aosp/2770702 , aosp/2781074 ) improve performance according to the benchmarks

Message last modified on Oct 12, 2023 09:22AM

pr...@google.com <pr...@google.com> #6Oct 18, 2023 08:42PM