Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d241259c7e2ffe8ebedd9cbff255cab54a900536
Author: Chris Craik <ccraik@google.com>
Date: Thu Oct 05 14:38:29 2023
Remove should from MicrobenchmarkConfig API
Fixes: 303387299
Test: ./gradlew bench:b-c:cC
Test: ./gradlew benchmark:b-c:updateApi
Relnote: "Renamed MicrobenchmarkConfig boolean parameters to avoid
unnecessary word 'should'"
```
Do, or do not. There is no should.
```
Change-Id: Ia8f009b76a7adfc081bf3e4a2e730393fd4d4af8
M benchmark/benchmark-common/api/current.txt
M benchmark/benchmark-common/api/restricted_current.txt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/MicrobenchmarkConfig.kt
M benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRule.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/MainThreadBenchmark.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoOverheadBenchmark.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoSdkOverheadBenchmark.kt
https://android-review.googlesource.com/2776443
Branch: androidx-main
commit d241259c7e2ffe8ebedd9cbff255cab54a900536
Author: Chris Craik <ccraik@google.com>
Date: Thu Oct 05 14:38:29 2023
Remove should from MicrobenchmarkConfig API
Fixes: 303387299
Test: ./gradlew bench:b-c:cC
Test: ./gradlew benchmark:b-c:updateApi
Relnote: "Renamed MicrobenchmarkConfig boolean parameters to avoid
unnecessary word 'should'"
```
Do, or do not. There is no should.
```
Change-Id: Ia8f009b76a7adfc081bf3e4a2e730393fd4d4af8
M benchmark/benchmark-common/api/current.txt
M benchmark/benchmark-common/api/restricted_current.txt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/MicrobenchmarkConfig.kt
M benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRule.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/MainThreadBenchmark.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoOverheadBenchmark.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoSdkOverheadBenchmark.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.3.0-alpha01androidx.benchmark:benchmark-junit4:1.3.0-alpha01
Description
Version used: 1.2.0-rc01
Devices/Android versions reproduced on: N/A
The API currently contains `shouldEnableTraceAppTag` and `shouldEnablePerfettoSdkTracing`. Removing `should` from both APIs shortens the names without sacrificing any clarity.