Support lambda version of padding modifier [303446559]

Assigned

Feature Request

compose-roadmap-proposal

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

Oct 4, 2023 07:58PM

Description: Please consider adding lambda support for padding modifier (similar to offset).

Use Case: Padding animations ends up with a lot of recompositions unlike offset. It would be good if recomposition can be skipped and if it can be optimized to just layout phase via developer specified lambda.

The following is the padding animation that ends up with a lot of recomposition as padding doesn't have a corresponding lambda version. Note an offset animation can be optimized via its lambda version (offset { IntOffset(...) })

var toggled by remember {
    mutableStateOf(false)
}
val animatedPadding by animateDpAsState(
    if (toggled) {
        0.dp
    } else {
        20.dp
    },
    label = "padding"
)
Box(
    modifier = Modifier
        .aspectRatio(1f)
        .fillMaxSize()
        .padding(animatedPadding)
        .background(Color(0xff53D9A1))
        .clickable(
            interactionSource = remember { MutableInteractionSource() },
            indication = null
        ) {
            toggled = !toggled
        }
)

Comments

br...@gmail.com <br...@gmail.com> #2Oct 20, 2023 11:43AM

Hello, can you please attach a sample that reproduces your error?

an...@google.com <an...@google.com> Oct 25, 2023 05:26PM

Assigned to co...@google.com.

br...@gmail.com <br...@gmail.com> #3Oct 27, 2023 06:20AM

I’ve attached two screen recordings demonstrating the mediator's behavior during the first and second launches after installation. Additionally, https://gist.github.com/yatiksihag01/20106aa4855bd438e3eb982034d4bb7d is link to a GitHub Gist containing the code for my remote mediator file for your reference.

Message last modified on Oct 27, 2023 01:08PM

sh...@google.com <sh...@google.com> Nov 2, 2023 11:13AM

Reassigned to jo...@google.com.

jo...@google.com <jo...@google.com> #4Nov 6, 2023 04:08PM

Reassigned to co...@google.com.

Based on first_launch_after_installation.mp4, your paging state is indeed showing null for nextKey, so it makes sense that Paging concluded there are no more items to load.

So I think the question is why the PagingState contains only an empty page and null values. My guess is either

RemoteMediator REFRESH actually returned empty data - what is the returned allNewsItems value on initial REFRESH?
RemoteMediator REFRESH successfully loaded data and inserted it into database, but Paging hasn't processed that yet by the time Append is triggered, so PagingState is empty.

The second case doesn't seem likely though.

If you attach an executable app, I can look into this further.

Otherwise, you may gain more insight through Paging logs with adb shell setprop log.tag.Paging VERBOSE. You can also try implementing RemoteKeys in this codelab which addresses possible races between Refresh and subsequent loads.

Issue 303446559