Status Update
No update yet.
Comments
bk...@gmail.com
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
dv...@gmail.com
no, just modify the code by yourself. I have fix that.
If you want to fix this by yourself, following the instructions in this document. you can use wsl in windows to download and compile the following source code.
or, you can use the AARs compiled by me. you need download the AARs, and refers in the build.gradle files.
// benchmark-macro use wireEnum
implementation("com.squareup.wire:wire-runtime:4.9.3")
// load androidx benchmark macro junit
// use MacrobenchmarkRule
implementation(files(localProperties.getProperty("benchmark-macro-junit4.file")))
// load androidx benchmark macro
// use CompilationMode，StartupMode
implementation(files(localProperties.getProperty("benchmark-macro.file")))
// load androidx benchmark common
//use Arguments
implementation(files(localProperties.getProperty("benchmark-common.file")))
and you should define path in local.properties, like this(you may need change the path , depends on where you save your files.
benchmark-common.file=..\\aar\\benchmark-common-release.aar
benchmark-macro-junit4.file=..\\aar\\benchmark-macro-junit4-release.aar
benchmark-macro.file=..\\aar\\benchmark-macro-release.aar
ap...@google.com
Branch: androidx-main
commit ec13e616312e4026429dfa6a86b820725f30e2be
Author: Chris Craik <ccraik@google.com>
Date: Wed Dec 06 09:59:35 2023
Fix FrameId parsing in FrameTimingMetric
Fixes: 303823815
Bug: 306235276
Test: SliceTest
Test: FrameTimingQueryTest
Relnote: "Fixed crash in FrameTimingMetric failing to parse frame id,
especially on certain OEM devices."
Change-Id: Ia24bc3c90b317252f579cc2425547f034ef96ef8
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/SliceTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/Slice.kt
cc...@google.com
The above fix should address the issue, and you can confirm it does with a snapshot build 11193231 or higher from
Add the following to your top-level build.gradle file:
allprojects {
repositories {
google()
mavenCentral()
maven { url 'https://androidx.dev/snapshots/builds/11193231/artifacts/repository' }
}
}
Together with the following in your macrobench module build.gradle:
dependencies {
implementation "androidx.benchmark:benchmark-macro-junit4:1.3.0-SNAPSHOT"
}
If this addresses the problem for you, we can release a bugfix release that includes this change.
The common case where this likely occurs is from
Note though that the original report in Choreographer#doFrame <frameid>. Since I didn't have a trace or device to reproduce that string on, I just took the first string after "doframe" in that case as that works for
dv...@gmail.com
maybe this fix should introduce a depth argument to control which depth level of doFrame to use.
cc...@google.com
It should be more common for apps/OS to add trace sections (even above doFrame) than it is for the OS to modify them, so I'd prefer to limit filtering based on content of the slice rather than depth.
While that would have avoided the #doFrame - resynced to issue, the change above matches how upstream Perfetto rejects those slices.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha01
Description
Component used: Macrobenchmark/FrameTimingMetric Version used: latest version Devices/Android versions reproduced on: android 13
I used Macrobenchmark to write a cold launching testcase .
I was collecting FrameTimingMetric by passing FrameTimingMetric in measureRepeated method.(please look screenshot I attach below). However I get the exception thrown by require statement.
I debugged the testcase, found that FrameId of Choreographer#doFrame is null.(please look screenshot I attach below)
because of the last substring divided by empty string of choreographer#doFrame is frame time ,not frameId.
could you fix that?
If this is a bug in the library, we would appreciate if you could attach: