Status Update
No update yet.
Comments
bk...@gmail.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
dv...@gmail.com
ap...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
cc...@google.com
The above fix should address the issue, and you can confirm it does with a snapshot build 11193231 or higher from
Add the following to your top-level build.gradle file:
allprojects {
repositories {
google()
mavenCentral()
maven { url 'https://androidx.dev/snapshots/builds/11193231/artifacts/repository' }
}
}
Together with the following in your macrobench module build.gradle:
dependencies {
implementation "androidx.benchmark:benchmark-macro-junit4:1.3.0-SNAPSHOT"
}
If this addresses the problem for you, we can release a bugfix release that includes this change.
The common case where this likely occurs is from
Note though that the original report in Choreographer#doFrame <frameid>. Since I didn't have a trace or device to reproduce that string on, I just took the first string after "doframe" in that case as that works for
dv...@gmail.com
maybe this fix should introduce a depth argument to control which depth level of doFrame to use.
cc...@google.com
It should be more common for apps/OS to add trace sections (even above doFrame) than it is for the OS to modify them, so I'd prefer to limit filtering based on content of the slice rather than depth.
While that would have avoided the #doFrame - resynced to issue, the change above matches how upstream Perfetto rejects those slices.
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha01
Description
Component used: Macrobenchmark/FrameTimingMetric Version used: latest version Devices/Android versions reproduced on: android 13
I used Macrobenchmark to write a cold launching testcase .
I was collecting FrameTimingMetric by passing FrameTimingMetric in measureRepeated method.(please look screenshot I attach below). However I get the exception thrown by require statement.
I debugged the testcase, found that FrameId of Choreographer#doFrame is null.(please look screenshot I attach below)
because of the last substring divided by empty string of choreographer#doFrame is frame time ,not frameId.
could you fix that?
If this is a bug in the library, we would appreciate if you could attach: