Visible DragAndDropNode reports that is is unattached during traversal [303904810]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Oct 6, 2023 09:31PM

Jetpack Compose version: 1.6.0-alpha07 Jetpack Compose component used: UI

A DragAndDropNode reports it is unattached and unable to traverse its children even though it appears to be visible on screen.

Regardless of its apparent visibility, a DragAndDropNode should not attempt to participate in drag and drop actions if it is not attached.

java.lang.IllegalStateException: visitChildren called on an unattached node
                                                               	at androidx.compose.ui.node.TraversableNodeKt.traverseChildren(TraversableNode.kt:595)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onStarted(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onDragAndDropEvent-deBgYiE(DragAndDropNode.kt:108)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode$onStarted$2.invoke(DragAndDropNode.kt:130)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode$onStarted$2.invoke(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.node.TraversableNodeKt.traverseChildren(TraversableNode.kt:154)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onStarted(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onDragAndDropEvent-deBgYiE(DragAndDropNode.kt:108)
                                                               	at androidx.compose.ui.platform.DragAndDropModifierOnDragListener.onDrag(AndroidComposeView.android.kt:2256)
                                                               	at android.view.View.callDragEventHandler(View.java:28363)
                                                               	at android.view.View.dispatchDragEvent(View.java:28354)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1742)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewRootImpl.handleDragEvent(ViewRootImpl.java:8232)
                                                               	at android.view.ViewRootImpl.-$$Nest$mhandleDragEvent(Unknown Source:0)
                                                               	at android.view.ViewRootImpl$ViewRootHandler.handleMessageImpl(ViewRootImpl.java:6214)
                                                               	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6068)
                                                               	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                               	at android.os.Looper.loopOnce(Looper.java:205)
                                                               	at android.os.Looper.loop(Looper.java:294)
                                                               	at android.app.ActivityThread.main(ActivityThread.java:8194)
                                                               	at java.lang.reflect.Method.invoke(Native Method)
                                                               	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
                                                               	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

drag-and-drop-crash.mp4

7.7 MB

Download

Comments

as...@google.com <as...@google.com> #2Oct 6, 2023 10:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Message last modified on Oct 6, 2023 10:34PM

da...@google.com <da...@google.com> #3Oct 6, 2023 11:10PM

comment#2 I'm not sure, but it did happen in a lazy staggered grid, so it may be.

ap...@google.com <ap...@google.com> #4Oct 10, 2023 11:22AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 836fd735a43ac68b018d98d398bd10a6f48773e7
Author: dahunsi <dahunsi@google.com>
Date: Tue Oct 03 13:50:54 2023

API review for drag and drop
Fixes: 302524019
Fixes: 303904810
Test: Added a new test for drag and drop nodes that were removed during a drag and drop session
Relnote: "Modifier.dragAndDrawSource has had the onDrawDragShadow lambda renamed to drawDragDecoration
DragAndDropInfo has had the size parameter renamed to dragDecorationSize"

Change-Id: Id0e3037697efad03dcf74c2c9393a733e6ab0489

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/DragAndDropSamples.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/draganddrop/AndroidDragAndDropSource.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/draganddrop/DragAndDropSource.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/draganddrop/AndroidDragAndDropTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/layout/Helpers.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/draganddrop/ComposeDragShadowBuilder.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
M compose/ui/ui/src/androidUnitTest/kotlin/androidx/compose/ui/node/ModifierLocalConsumerEntityTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draganddrop/DragAndDropManager.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draganddrop/DragAndDropNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.desktop.kt
M compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaBasedOwner.skiko.kt

https://android-review.googlesource.com/2769982

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.6.0-alpha08
androidx.compose.foundation:foundation-android:1.6.0-alpha08
androidx.compose.foundation:foundation-desktop:1.6.0-alpha08
androidx.compose.ui:ui:1.6.0-alpha08
androidx.compose.ui:ui-android:1.6.0-alpha08
androidx.compose.ui:ui-desktop:1.6.0-alpha08

da...@bandlab.com <da...@bandlab.com> #6Jan 9, 2024 09:42AM

We have a `LazyList` with horizontal swipe actions on the items. The crash is still reproducible on latest alpha, but with different stack trace.
It happens by just scrolling the list, quickly, multiple times

java.lang.IllegalArgumentException: measure is called on a deactivated node
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:604)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:354)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout-0kLqBqw(MeasureAndLayoutDelegate.kt:434)
at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout-0kLqBqw(AndroidComposeView.android.kt:982)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$precompose$2.premeasure-0kLqBqw(SubcomposeLayout.kt:811)
at androidx.compose.foundation.lazy.layout.LazyLayoutPrefetcher.run(LazyLayoutPrefetcher.android.kt:195)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:236)
at android.app.ActivityThread.main(ActivityThread.java:8060)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)

an...@google.com <an...@google.com> #7Jan 9, 2024 01:06PM

This crash was fixed as part of https://issuetracker.google.com/issues/316683578

Issue 303904810