Visible DragAndDropNode reports that is is unattached during traversal [303904810]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Oct 6, 2023 09:31PM

Jetpack Compose version: 1.6.0-alpha07 Jetpack Compose component used: UI

A DragAndDropNode reports it is unattached and unable to traverse its children even though it appears to be visible on screen.

Regardless of its apparent visibility, a DragAndDropNode should not attempt to participate in drag and drop actions if it is not attached.

java.lang.IllegalStateException: visitChildren called on an unattached node
                                                               	at androidx.compose.ui.node.TraversableNodeKt.traverseChildren(TraversableNode.kt:595)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onStarted(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onDragAndDropEvent-deBgYiE(DragAndDropNode.kt:108)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode$onStarted$2.invoke(DragAndDropNode.kt:130)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode$onStarted$2.invoke(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.node.TraversableNodeKt.traverseChildren(TraversableNode.kt:154)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onStarted(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onDragAndDropEvent-deBgYiE(DragAndDropNode.kt:108)
                                                               	at androidx.compose.ui.platform.DragAndDropModifierOnDragListener.onDrag(AndroidComposeView.android.kt:2256)
                                                               	at android.view.View.callDragEventHandler(View.java:28363)
                                                               	at android.view.View.dispatchDragEvent(View.java:28354)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1742)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewRootImpl.handleDragEvent(ViewRootImpl.java:8232)
                                                               	at android.view.ViewRootImpl.-$$Nest$mhandleDragEvent(Unknown Source:0)
                                                               	at android.view.ViewRootImpl$ViewRootHandler.handleMessageImpl(ViewRootImpl.java:6214)
                                                               	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6068)
                                                               	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                               	at android.os.Looper.loopOnce(Looper.java:205)
                                                               	at android.os.Looper.loop(Looper.java:294)
                                                               	at android.app.ActivityThread.main(ActivityThread.java:8194)
                                                               	at java.lang.reflect.Method.invoke(Native Method)
                                                               	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
                                                               	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

drag-and-drop-crash.mp4

7.7 MB

Download

Comments

as...@google.com <as...@google.com> #2Oct 6, 2023 10:34PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

Message last modified on Oct 6, 2023 10:34PM

da...@google.com <da...@google.com> #3Oct 6, 2023 11:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ap...@google.com <ap...@google.com> #4Oct 10, 2023 11:22AM

Marked as fixed.

deleted

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

da...@bandlab.com <da...@bandlab.com> #6Jan 9, 2024 09:42AM

We have a `LazyList` with horizontal swipe actions on the items. The crash is still reproducible on latest alpha, but with different stack trace.
It happens by just scrolling the list, quickly, multiple times

java.lang.IllegalArgumentException: measure is called on a deactivated node
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:604)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:354)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout-0kLqBqw(MeasureAndLayoutDelegate.kt:434)
at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout-0kLqBqw(AndroidComposeView.android.kt:982)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$precompose$2.premeasure-0kLqBqw(SubcomposeLayout.kt:811)
at androidx.compose.foundation.lazy.layout.LazyLayoutPrefetcher.run(LazyLayoutPrefetcher.android.kt:195)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:236)
at android.app.ActivityThread.main(ActivityThread.java:8060)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)

an...@google.com <an...@google.com> #7Jan 9, 2024 01:06PM

This crash was fixed as part of https://issuetracker.google.com/issues/316683578

Issue 303904810