Visible DragAndDropNode reports that is is unattached during traversal [303904810]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Oct 6, 2023 09:31PM

Jetpack Compose version: 1.6.0-alpha07 Jetpack Compose component used: UI

A DragAndDropNode reports it is unattached and unable to traverse its children even though it appears to be visible on screen.

Regardless of its apparent visibility, a DragAndDropNode should not attempt to participate in drag and drop actions if it is not attached.

java.lang.IllegalStateException: visitChildren called on an unattached node
                                                               	at androidx.compose.ui.node.TraversableNodeKt.traverseChildren(TraversableNode.kt:595)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onStarted(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onDragAndDropEvent-deBgYiE(DragAndDropNode.kt:108)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode$onStarted$2.invoke(DragAndDropNode.kt:130)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode$onStarted$2.invoke(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.node.TraversableNodeKt.traverseChildren(TraversableNode.kt:154)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onStarted(DragAndDropNode.kt:129)
                                                               	at androidx.compose.ui.draganddrop.DragAndDropNode.onDragAndDropEvent-deBgYiE(DragAndDropNode.kt:108)
                                                               	at androidx.compose.ui.platform.DragAndDropModifierOnDragListener.onDrag(AndroidComposeView.android.kt:2256)
                                                               	at android.view.View.callDragEventHandler(View.java:28363)
                                                               	at android.view.View.dispatchDragEvent(View.java:28354)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1742)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewGroup.notifyChildOfDragStart(ViewGroup.java:1888)
                                                               	at android.view.ViewGroup.dispatchDragEvent(ViewGroup.java:1735)
                                                               	at android.view.ViewRootImpl.handleDragEvent(ViewRootImpl.java:8232)
                                                               	at android.view.ViewRootImpl.-$$Nest$mhandleDragEvent(Unknown Source:0)
                                                               	at android.view.ViewRootImpl$ViewRootHandler.handleMessageImpl(ViewRootImpl.java:6214)
                                                               	at android.view.ViewRootImpl$ViewRootHandler.handleMessage(ViewRootImpl.java:6068)
                                                               	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                               	at android.os.Looper.loopOnce(Looper.java:205)
                                                               	at android.os.Looper.loop(Looper.java:294)
                                                               	at android.app.ActivityThread.main(ActivityThread.java:8194)
                                                               	at java.lang.reflect.Method.invoke(Native Method)
                                                               	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
                                                               	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

drag-and-drop-crash.mp4

7.7 MB

Download

Comments

as...@google.com <as...@google.com> #2Oct 6, 2023 10:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

Message last modified on Oct 6, 2023 10:34PM

da...@google.com <da...@google.com> #3Oct 6, 2023 11:10PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Oct 10, 2023 11:22AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.6.0-alpha08
androidx.compose.foundation:foundation-android:1.6.0-alpha08
androidx.compose.foundation:foundation-desktop:1.6.0-alpha08
androidx.compose.ui:ui:1.6.0-alpha08
androidx.compose.ui:ui-android:1.6.0-alpha08
androidx.compose.ui:ui-desktop:1.6.0-alpha08

da...@bandlab.com <da...@bandlab.com> #6Jan 9, 2024 09:42AM

We have a `LazyList` with horizontal swipe actions on the items. The crash is still reproducible on latest alpha, but with different stack trace.
It happens by just scrolling the list, quickly, multiple times

java.lang.IllegalArgumentException: measure is called on a deactivated node
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:604)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:354)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout-0kLqBqw(MeasureAndLayoutDelegate.kt:434)
at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout-0kLqBqw(AndroidComposeView.android.kt:982)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$precompose$2.premeasure-0kLqBqw(SubcomposeLayout.kt:811)
at androidx.compose.foundation.lazy.layout.LazyLayoutPrefetcher.run(LazyLayoutPrefetcher.android.kt:195)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:236)
at android.app.ActivityThread.main(ActivityThread.java:8060)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)

an...@google.com <an...@google.com> #7Jan 9, 2024 01:06PM

This crash was fixed as part of https://issuetracker.google.com/issues/316683578

Issue 303904810