PerfettoTraceProcessor.Session#getTraceMetrics only supports "android_startup", need support more [304038382]

Fixed

Bug

Status Update

No update yet.

Description

dv...@gmail.com

created issue #1

Oct 8, 2023 08:54AM

Component used:PerfettoTraceProcessor.Session in Macrobenchmark Version used: latest version Devices/Android versions reproduced on: 13

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

I extend Metric by TraceMetric.

In TraceMetric#getResult method, I want to call traceSession#getTraceMetric("android_frame_timeline_metric") to get frame timeline stats result.however it seems not support this "android_frame_timeline_metric", only supports "android_startup". so, how can I let it support android_frame_timeline_metric?

I have read the codes, but don't understand under the hook. could you explain it? how to support all Metrics in perfetto?(in screenshot)

Sun Oct 08 2023 16:42:05 GMT+0800 (China Standard Time).png

246 KB

View

Download

Sun Oct 08 2023 16:53:05 GMT+0800 (China Standard Time).png

64 KB

View

Download

Comments

cc...@google.com <cc...@google.com> #2Oct 9, 2023 06:59PM

With the change of lifecycle-common to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime, which does work).

dv...@gmail.com <dv...@gmail.com> #3Oct 11, 2023 12:34AM

lifecycle-common even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.

cc...@google.com <cc...@google.com> #4Oct 19, 2023 05:51PM

Reassigned to ma...@google.com.

Ah yeah good point.

dv...@gmail.com <dv...@gmail.com> #5Nov 14, 2023 12:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024

Move baseline-prof.txt from Lifecycle common to runtime

* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.

Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347

D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt

https://android-review.googlesource.com/3038274

pr...@google.com <pr...@google.com> Mar 7, 2024 09:31PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #6Mar 14, 2024 04:18PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 82d329d98386bc868c727bbc029cc4a5e48b9c0e
Author: Chris Craik <ccraik@google.com>
Date: Tue Feb 27 11:50:52 2024

Improve perfetto metrics API

Fixes: 304038382
Relnote: "Adds public API PerfettoTraceProcessor.Session.queryMetrics*** APIs
with JSON, textproto, and proto binary (undecoded) variants."
Test: PerfettoTraceProcessorTest

Change-Id: I54d7fb0cfd2d6e448bda78d9397cb96d77a2125b

M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt

https://android-review.googlesource.com/2998126

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.3.0-alpha03