Status Update
No update yet.
Comments
cc...@google.com
To make this public and genertic, we need to expose a binary version of getTraceMetrics, which takes a string or list of strings, and returns a bytearray.
Unfortunately, this means you'll need to decode the output proto, since androidx has a policy of not exposing proto apis directly.
dv...@gmail.com
Could you give a example how to decode the output of traceSession#getTraceMetric("android_frame_timeline_metric")
cc...@google.com
You'd need a proto library (in macrobenchmark we use
With wire, and once we add that binary API, that would look something like:
val frameTimelineMetric = TraceMetrics.parse(
traceSession.getTraceMetricByteArray("android_frame_timeline_metric")
).android_frame_timeline_metric!!
Over to Marcello, since we could do this as part of giving PerfettoTraceProcessor a better home.
dv...@gmail.com
thank you
pr...@google.com
ap...@google.com
Branch: androidx-main
commit 82d329d98386bc868c727bbc029cc4a5e48b9c0e
Author: Chris Craik <ccraik@google.com>
Date: Tue Feb 27 11:50:52 2024
Improve perfetto metrics API
Fixes: 304038382
Relnote: "Adds public API PerfettoTraceProcessor.Session.queryMetrics*** APIs
with JSON, textproto, and proto binary (undecoded) variants."
Test: PerfettoTraceProcessorTest
Change-Id: I54d7fb0cfd2d6e448bda78d9397cb96d77a2125b
M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha03
Description
Component used:PerfettoTraceProcessor.Session in Macrobenchmark Version used: latest version Devices/Android versions reproduced on: 13
If this is a bug in the library, we would appreciate if you could attach:
I extend Metric by TraceMetric.
In TraceMetric#getResult method, I want to call traceSession#getTraceMetric("android_frame_timeline_metric") to get frame timeline stats result.however it seems not support this "android_frame_timeline_metric", only supports "android_startup". so, how can I let it support android_frame_timeline_metric?
I have read the codes, but don't understand under the hook. could you explain it? how to support all Metrics in perfetto?(in screenshot)