PerfettoTraceProcessor.Session#getTraceMetrics only supports "android_startup", need support more [304038382]

Fixed

Bug

Status Update

No update yet.

Description

dv...@gmail.com

created issue #1

Oct 8, 2023 08:54AM

Component used:PerfettoTraceProcessor.Session in Macrobenchmark Version used: latest version Devices/Android versions reproduced on: 13

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

I extend Metric by TraceMetric.

In TraceMetric#getResult method, I want to call traceSession#getTraceMetric("android_frame_timeline_metric") to get frame timeline stats result.however it seems not support this "android_frame_timeline_metric", only supports "android_startup". so, how can I let it support android_frame_timeline_metric?

I have read the codes, but don't understand under the hook. could you explain it? how to support all Metrics in perfetto?(in screenshot)

Sun Oct 08 2023 16:42:05 GMT+0800 (China Standard Time).png

246 KB

View

Download

Sun Oct 08 2023 16:53:05 GMT+0800 (China Standard Time).png

64 KB

View

Download

Comments

cc...@google.com <cc...@google.com> #2Oct 9, 2023 06:59PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

dv...@gmail.com <dv...@gmail.com> #3Oct 11, 2023 12:34AM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

cc...@google.com <cc...@google.com> #4Oct 19, 2023 05:51PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

dv...@gmail.com <dv...@gmail.com> #5Nov 14, 2023 12:37PM

thank you

pr...@google.com <pr...@google.com> Mar 7, 2024 09:31PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #6Mar 14, 2024 04:18PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 82d329d98386bc868c727bbc029cc4a5e48b9c0e
Author: Chris Craik <ccraik@google.com>
Date: Tue Feb 27 11:50:52 2024

Improve perfetto metrics API

Fixes: 304038382
Relnote: "Adds public API PerfettoTraceProcessor.Session.queryMetrics*** APIs
with JSON, textproto, and proto binary (undecoded) variants."
Test: PerfettoTraceProcessorTest

Change-Id: I54d7fb0cfd2d6e448bda78d9397cb96d77a2125b

M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt

https://android-review.googlesource.com/2998126

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.3.0-alpha03