PerfettoTraceProcessor.Session#getTraceMetrics only supports "android_startup", need support more [304038382]

Fixed

Bug

Status Update

No update yet.

Description

dv...@gmail.com

created issue #1

Oct 8, 2023 08:54AM

Component used:PerfettoTraceProcessor.Session in Macrobenchmark Version used: latest version Devices/Android versions reproduced on: 13

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

I extend Metric by TraceMetric.

In TraceMetric#getResult method, I want to call traceSession#getTraceMetric("android_frame_timeline_metric") to get frame timeline stats result.however it seems not support this "android_frame_timeline_metric", only supports "android_startup". so, how can I let it support android_frame_timeline_metric?

I have read the codes, but don't understand under the hook. could you explain it? how to support all Metrics in perfetto?(in screenshot)

Sun Oct 08 2023 16:42:05 GMT+0800 (China Standard Time).png

246 KB

View

Download

Sun Oct 08 2023 16:53:05 GMT+0800 (China Standard Time).png

64 KB

View

Download

Comments

cc...@google.com <cc...@google.com> #2Oct 9, 2023 06:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

dv...@gmail.com <dv...@gmail.com> #3Oct 11, 2023 12:34AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

cc...@google.com <cc...@google.com> #4Oct 19, 2023 05:51PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

dv...@gmail.com <dv...@gmail.com> #5Nov 14, 2023 12:37PM

thank you

pr...@google.com <pr...@google.com> Mar 7, 2024 09:31PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #6Mar 14, 2024 04:18PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 82d329d98386bc868c727bbc029cc4a5e48b9c0e
Author: Chris Craik <ccraik@google.com>
Date: Tue Feb 27 11:50:52 2024

Improve perfetto metrics API

Fixes: 304038382
Relnote: "Adds public API PerfettoTraceProcessor.Session.queryMetrics*** APIs
with JSON, textproto, and proto binary (undecoded) variants."
Test: PerfettoTraceProcessorTest

Change-Id: I54d7fb0cfd2d6e448bda78d9397cb96d77a2125b

M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt

https://android-review.googlesource.com/2998126

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.3.0-alpha03