Macrobenchmark Should let Metric class add more datasources to perfettoConfig [304038384]

Assigned

Bug

Status Update

No update yet.

Description

dv...@gmail.com

created issue #1

Oct 8, 2023 09:26AM

Component used: Metric Version used: latest Devices/Android versions reproduced on: Android 13, Oneplus 11

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

When I add some new metric, I need add new Perfetto trace datasource to capture.

But there is no way to modify the PerfettoConfig class , default is PerfettonConfig.benchmark

Can you modify the macrobenchmark architecture , let Metric class has a changes to add datasource used in benchmarktest?

Sun Oct 08 2023 17:23:55 GMT+0800 (China Standard Time).png

49 KB

View

Download

Comments

cc...@google.com <cc...@google.com> #2Oct 23, 2023 10:32PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

dv...@gmail.com <dv...@gmail.com> #3Dec 19, 2023 12:26PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

Message last modified on Dec 19, 2023 12:29PM

cc...@google.com <cc...@google.com> #4Apr 11, 2024 10:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

cc...@google.com <cc...@google.com> #5Apr 11, 2024 10:26PM

InMemoryTrace

My instinct is to avoid using InMemoryTrace in macrobenchmark entirely, as traces can be arbitrarily long, so the cost of --full-sort is likely not worth the benefit, at least in how macrobenchmark uses it. InMemoryTrace is most useful for microbenchmark - injecting trace events after the fact, at 0 cost during very sensitive measurement, and with limited trace durations.

You can consider using PerfettoSdkTrace from androidx.tracing:tracing-perfetto if you want additional tracepoints, though this adds startup complexity and requires an instrumentation arg

Probably worth a separate bug if we want to discuss further.

ap...@google.com <ap...@google.com> #6Apr 12, 2024 10:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5d5db95b1b823a1a174fbfc11fa6589c5988f378
Author: Chris Craik <ccraik@google.com>
Date: Thu Apr 11 15:04:05 2024

Enable passing custom PerfettoConfig to Macrobenchmark

Test: MacrobenchmarkTest
Test: ./gradlew benchmark:benchmark-macro:lintDebug
Fixes: 309841164
Bug: 304038384
Relnote: "Added experimental MacrobenchmarkRule#measureRepeated
variant which takes a custom PerfettoConfig for fully customized
Perfetto trace recording. Note that incorrectly configured configs may
cause built in Metric classes to fail."

Change-Id: Idfd3d0c071005f04f8be9975c6379e6095416775

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt
M benchmark/benchmark-macro-junit4/api/current.txt
M benchmark/benchmark-macro-junit4/api/restricted_current.txt
M benchmark/benchmark-macro-junit4/build.gradle
M benchmark/benchmark-macro-junit4/src/main/java/androidx/benchmark/macro/junit4/MacrobenchmarkRule.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt

https://android-review.googlesource.com/3038761

Issue 304038384