Macrobenchmark Should let Metric class add more datasources to perfettoConfig [304038384]

Assigned

Bug

Status Update

No update yet.

Description

dv...@gmail.com

created issue #1

Oct 8, 2023 09:26AM

Component used: Metric Version used: latest Devices/Android versions reproduced on: Android 13, Oneplus 11

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

When I add some new metric, I need add new Perfetto trace datasource to capture.

But there is no way to modify the PerfettoConfig class , default is PerfettonConfig.benchmark

Can you modify the macrobenchmark architecture , let Metric class has a changes to add datasource used in benchmarktest?

Sun Oct 08 2023 17:23:55 GMT+0800 (China Standard Time).png

49 KB

View

Download

Comments

cc...@google.com <cc...@google.com> #2Oct 23, 2023 10:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

dv...@gmail.com <dv...@gmail.com> #3Dec 19, 2023 12:26PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Message last modified on Dec 19, 2023 12:29PM

cc...@google.com <cc...@google.com> #4Apr 11, 2024 10:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

cc...@google.com <cc...@google.com> #5Apr 11, 2024 10:26PM

InMemoryTrace

My instinct is to avoid using InMemoryTrace in macrobenchmark entirely, as traces can be arbitrarily long, so the cost of --full-sort is likely not worth the benefit, at least in how macrobenchmark uses it. InMemoryTrace is most useful for microbenchmark - injecting trace events after the fact, at 0 cost during very sensitive measurement, and with limited trace durations.

You can consider using PerfettoSdkTrace from androidx.tracing:tracing-perfetto if you want additional tracepoints, though this adds startup complexity and requires an instrumentation arg

Probably worth a separate bug if we want to discuss further.

ap...@google.com <ap...@google.com> #6Apr 12, 2024 10:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5d5db95b1b823a1a174fbfc11fa6589c5988f378
Author: Chris Craik <ccraik@google.com>
Date: Thu Apr 11 15:04:05 2024

Enable passing custom PerfettoConfig to Macrobenchmark

Test: MacrobenchmarkTest
Test: ./gradlew benchmark:benchmark-macro:lintDebug
Fixes: 309841164
Bug: 304038384
Relnote: "Added experimental MacrobenchmarkRule#measureRepeated
variant which takes a custom PerfettoConfig for fully customized
Perfetto trace recording. Note that incorrectly configured configs may
cause built in Metric classes to fail."

Change-Id: Idfd3d0c071005f04f8be9975c6379e6095416775

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt
M benchmark/benchmark-macro-junit4/api/current.txt
M benchmark/benchmark-macro-junit4/api/restricted_current.txt
M benchmark/benchmark-macro-junit4/build.gradle
M benchmark/benchmark-macro-junit4/src/main/java/androidx/benchmark/macro/junit4/MacrobenchmarkRule.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt

https://android-review.googlesource.com/3038761

Issue 304038384