Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit ba26df6d0b7d42696e502602f1439c2a9fed4472
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Dec 06 09:41:36 2023
Optimize binding storage in AndroidSQLiteStatement
Specifically use arrays for the primitive binding types instead of a List of Object to avoid primitives boxing.
Bug: 304299101
Test: BaseConformanceTest
Change-Id: If4bf10ea1c9e79532bb6f7d8c06efe4590ac6591
M sqliteMultiplatform/conformanceTest/src/commonMain/kotlin/androidx/sqliteMultiplatform/BaseConformanceTest.kt
M sqliteMultiplatform/sqlite-driver/src/androidMain/kotlin/androidx/sqliteMultiplatform/driver/AndroidSQLiteStatement.kt
https://android-review.googlesource.com/2863968
Branch: androidx-main
commit ba26df6d0b7d42696e502602f1439c2a9fed4472
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Dec 06 09:41:36 2023
Optimize binding storage in AndroidSQLiteStatement
Specifically use arrays for the primitive binding types instead of a List of Object to avoid primitives boxing.
Bug: 304299101
Test: BaseConformanceTest
Change-Id: If4bf10ea1c9e79532bb6f7d8c06efe4590ac6591
M sqliteMultiplatform/conformanceTest/src/commonMain/kotlin/androidx/sqliteMultiplatform/BaseConformanceTest.kt
M sqliteMultiplatform/sqlite-driver/src/androidMain/kotlin/androidx/sqliteMultiplatform/driver/AndroidSQLiteStatement.kt
da...@google.com <da...@google.com> #3
I thought about using androidx.collection and its various boxing avoiding collections, LongList
, DoubleList
but I am blocked on
Description
In the Android driver implementation, during binding of arguments, auto-boxing should be avoided same as sqlite-framework.