Bug P2
Status Update
Comments
da...@mullvad.net <da...@mullvad.net> #2
Hi. Thanks for reporting this. Fixed in alpha-04
da...@mullvad.net <da...@mullvad.net> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
da...@mullvad.net <da...@mullvad.net> #4
deleted
pj...@gmail.com <pj...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
kl...@google.com <kl...@google.com> #6
Added some logging, it looks like the dialog gets the ACTION_DOWN
event, but the main window gets the ACTION_UP
event. If I replace the list with Android views, this does not happen.
I think probably Compose's Material Button
should not treat an UP
without a DOWN
as a click.
Or better yet, according to
da...@mullvad.net <da...@mullvad.net> #7
I tested this on the latest version of compose, seems to work correctly now.
Description
TextField with
singleLine = true
does not consume the enter key. It passedimeOptions(singleLine = true)
but IME never consumes the click. This becomes a problem when using a TextField in a dialog since focus is still on a list item in the back. Pressing enter while focusing the TextField will then cause the button in the list view in the background to be pressed again.Here is a snippet with the issue at hand:
I've also attached a recording of the issue, I first navigate with keyboard enter the dialog and focus the TextField, enter some text and then press enter to finish my modification. This causes the dialog to close but also trigger a onClick on the button (named "Row 2") in the background thus causing the dialog to open again. On the second dialog I go to the "Confirm" button and press enter instead, this correctly consumes the press and simply closes the dialog.