Provide an api for getting an amount of visible children [305905580]

Assigned

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Oct 17, 2023 10:42AM

There are usecases when users want to know the amount of visible children to assert it with the expected one. The current workaround could be something like:

    rule.onAllNodesWithText("item", substring = true)
        .filter(isPlaced())
        .assertCountEquals(1)
    
    ...
    
    fun isPlaced() = SemanticsMatcher("isPlaced") { node -> node.layoutInfo.isPlaced }

But we need to provide an official api for this use case as well See: https://b.corp.google.com/issues/187188981#comment11 for the original discussion.

Comments

ap...@google.com <ap...@google.com> #2Dec 22, 2023 03:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit df7e5823b5e0ad1a1da88a71b44708597848769f
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Wed Dec 20 14:18:39 2023

Filter out deactivated nodes from SemanticNodes.children

In aosp/2787059 we started filtering out the deactivated nodes so users can't see them in their tests. However one use case was missed:

rule.onNodeWithTag("list")
.onChildren().assertCountEquals(expectedCount)

This code will still see the deactivated nodes as we are not filtering out deactivated nodes in the list returned by SemanticNode.children.

Test: new test in SubcomposeLayoutTest
Bug: 187188981
Bug: 305905580
Fixes: 317202262
Change-Id: I4fd3d6248fc5a24bdadfdd5c60afe31386fcf7d7

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/layout/SubcomposeLayoutTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsOwner.kt

https://android-review.googlesource.com/2885026

Issue 305905580

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Dec 22, 2023 03:26PM

Add comment

Issue metadata