Crash on Samsung A52 when image format is jpeg [306202751]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 19, 2023 11:33AM

CAMERAX VERSION 1.4.0-alpha01

ANDROID OS BUILD NUMBER: Android 12 and Android 13 DEVICE NAME: Samsung A52

DESCRIPTION:

On some Samsung A52 devices the image capture request does not succeed. It seems that it cant proccess the image because of missing metadata. This behaviour is only observed when using jpeg as output format. YUV format is working fine.

STEPS TO REPRODUCE:

Configure camera with jpeg as output format
Configure preview and image capture use case
Issue takePicture() with ImageCapture.OnImageCapturedCallback()

OBSERVED RESULTS:

Exception java.lang.IllegalStateException:
  at androidx.core.util.Preconditions.checkState (Preconditions.java:169)
  at androidx.camera.core.imagecapture.NoMetadataImageReader.acceptProcessingRequest (NoMetadataImageReader.java:69)
  at androidx.camera.core.imagecapture.CaptureNode.lambda$transform$0$androidx-camera-core-imagecapture-CaptureNode (CaptureNode.java:122)
  at androidx.camera.core.imagecapture.CaptureNode$$ExternalSyntheticLambda1.accept
  at androidx.camera.core.processing.Edge.accept (Edge.java:42)
  at androidx.camera.core.imagecapture.ImagePipeline.submitProcessingRequest (ImagePipeline.java:208)
  at androidx.camera.core.imagecapture.TakePictureManager.issueNextRequest (TakePictureManager.java:213)
  at androidx.camera.core.imagecapture.TakePictureManager.offerRequest (TakePictureManager.java:117)
  at androidx.camera.core.ImageCapture.takePictureInternal (ImageCapture.java:1044)
  at androidx.camera.core.ImageCapture.takePicture (ImageCapture.java:719)
  at androidx.camera.core.ImageCapture.lambda$takePicture$1$androidx-camera-core-ImageCapture (ImageCapture.java:715)
  at androidx.camera.core.ImageCapture$$ExternalSyntheticLambda4.run
  at android.os.Handler.handleCallback (Handler.java:942)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8741)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:571)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1067)

EXPECTED RESULTS: onCaptureSuccess Callback is called

REPRODUCIBILITY: 1 of 5

Comments

wu...@google.com <wu...@google.com> #2Oct 20, 2023 12:02AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

sc...@google.com <sc...@google.com> #3Oct 20, 2023 04:50AM

Hi Thanks for reporting the issue. To have more context, can you help provide the following information ?

Can you show us how you configure the ImageCapture in the codes ?
Did you enable CameraX Extensions ?
so the occurrence rate is like 20%, right ?

jo...@gmail.com <jo...@gmail.com> #4Oct 23, 2023 03:50PM

Thanks for your response.

Sure. I can provide more data.

ImageCapture.Builder builder = new ImageCapture.Builder();
builder.setCaptureMode(ImageCapture.CAPTURE_MODE_MINIMIZE_LATENCY);

if (!extensionAvailable) {
    builder.setBufferFormat(ImageFormat.YUV_420_888);
}

imageCapture = builder.build();

UseCaseGroup useCaseGroup = new UseCaseGroup.Builder()
                    .addUseCase(preview)
                    .addUseCase(imageCapture)
                    .setViewPort(viewPort)
                    .build();

cameraProvider.unbindAll();
camera = cameraProvider.bindToLifecycle(this, cameraSelector, useCaseGroup);

Yes, Extensions are enabled, which means that the code is not configuring the buffer format and therefore will use the JPEG format. If I disable the extensions, than the error disapears. But I think its more a jpeg format issue then an extension problem.
Yes, occurrence rate is 20%.

sc...@google.com <sc...@google.com> #5Oct 24, 2023 07:02AM

Reassigned to sc...@google.com.

Thanks for the information! We will look into this.

sc...@google.com <sc...@google.com> Oct 25, 2023 09:37AM

Accepted by sc...@google.com.

jo...@gmail.com <jo...@gmail.com> #6Dec 12, 2023 09:21AM

Any updates on this?

sc...@google.com <sc...@google.com> #7Dec 14, 2023 04:52AM

Yes, we are able to reproduce it and are developing a fix to this.

ap...@google.com <ap...@google.com> #8Dec 22, 2023 04:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 366c0b3e157615a4eb7f4597166bf30e0f1c9bdd
Author: Scott Nien <scottnien@google.com>
Date: Thu Dec 14 17:52:42 2023

Fixed the issue when takePicture with Extensions is interruped by lifecycle stop and it can't takePicture anymore after lifecyce start.

1. Handling the image of aborted request in CaptureNode
- When request is aborted, clear the pending request in NoMetadataImageReader
to avoid crash when next request is available.

- When incoming image has null stageId, close the image instead
of crash since this is the case when aborted request
still produce image.

2. Run the CaptureProcessorImpl.process() in non-camera thread instead.
to avoid it from blocking the camera thread which will freeze the preview.

Bug: 306202751
Test: CaptureNodeTest, extensions/ImageCaptureTest
Relnote: "Fixed the crash that happens when lifecycle is stopped before
takePicture request is completed"

Change-Id: Idf017ef3ec1400955066433dd8446f94728b8a1a

M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/CaptureNode.java
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/NoMetadataImageReader.java
M camera/camera-core/src/test/java/androidx/camera/core/imagecapture/CaptureNodeTest.kt
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/ImageCaptureTest.kt
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/AdvancedVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/BasicVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/sessionprocessor/BasicExtenderSessionProcessor.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/sessionprocessor/StillCaptureProcessor.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/fakes/FakeImageReaderProxy.java
M camera/camera-testlib-extensions/src/main/java/androidx/camera/extensions/impl/NightImageCaptureExtenderImpl.java
M camera/camera-testlib-extensions/src/main/java/androidx/camera/extensions/impl/advanced/LongCaptureAdvancedExtenderImpl.java

https://android-review.googlesource.com/2875502

sc...@google.com <sc...@google.com> Dec 22, 2023 06:33AM

Marked as fixed.

na...@google.com <na...@google.com> #9Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.4.0-alpha04
androidx.camera:camera-extensions:1.4.0-alpha04