Crash on Samsung A52 when image format is jpeg [306202751]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 19, 2023 11:33AM

CAMERAX VERSION 1.4.0-alpha01

ANDROID OS BUILD NUMBER: Android 12 and Android 13 DEVICE NAME: Samsung A52

DESCRIPTION:

On some Samsung A52 devices the image capture request does not succeed. It seems that it cant proccess the image because of missing metadata. This behaviour is only observed when using jpeg as output format. YUV format is working fine.

STEPS TO REPRODUCE:

Configure camera with jpeg as output format
Configure preview and image capture use case
Issue takePicture() with ImageCapture.OnImageCapturedCallback()

OBSERVED RESULTS:

Exception java.lang.IllegalStateException:
  at androidx.core.util.Preconditions.checkState (Preconditions.java:169)
  at androidx.camera.core.imagecapture.NoMetadataImageReader.acceptProcessingRequest (NoMetadataImageReader.java:69)
  at androidx.camera.core.imagecapture.CaptureNode.lambda$transform$0$androidx-camera-core-imagecapture-CaptureNode (CaptureNode.java:122)
  at androidx.camera.core.imagecapture.CaptureNode$$ExternalSyntheticLambda1.accept
  at androidx.camera.core.processing.Edge.accept (Edge.java:42)
  at androidx.camera.core.imagecapture.ImagePipeline.submitProcessingRequest (ImagePipeline.java:208)
  at androidx.camera.core.imagecapture.TakePictureManager.issueNextRequest (TakePictureManager.java:213)
  at androidx.camera.core.imagecapture.TakePictureManager.offerRequest (TakePictureManager.java:117)
  at androidx.camera.core.ImageCapture.takePictureInternal (ImageCapture.java:1044)
  at androidx.camera.core.ImageCapture.takePicture (ImageCapture.java:719)
  at androidx.camera.core.ImageCapture.lambda$takePicture$1$androidx-camera-core-ImageCapture (ImageCapture.java:715)
  at androidx.camera.core.ImageCapture$$ExternalSyntheticLambda4.run
  at android.os.Handler.handleCallback (Handler.java:942)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8741)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:571)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1067)

EXPECTED RESULTS: onCaptureSuccess Callback is called

REPRODUCIBILITY: 1 of 5

Comments

wu...@google.com <wu...@google.com> #2Oct 20, 2023 12:02AM

This was fixed in

https://issuetracker.google.com/issues/134673465

which is part of Fragments 1.2.0-alpha01:

https://developer.android.com/jetpack/androidx/releases/fragment#1.2.0-alpha01

Can you upgrade Fragments and see if this fixes your issue?

sc...@google.com <sc...@google.com> #3Oct 20, 2023 04:50AM

After update to Fragments 1.2.0-alpha01, it seems the same exception still happens (Also tried update appcompat:1.1.0-rc01)
The latest example project was attached

jo...@gmail.com <jo...@gmail.com> #4Oct 23, 2023 03:50PM

Sorry, <ma...@cyberagent.co.jp> is also my mail.

sc...@google.com <sc...@google.com> #5Oct 24, 2023 07:02AM

Reassigned to sc...@google.com.

Thanks for confirming, I was able to reproduce your issue.

sc...@google.com <sc...@google.com> Oct 25, 2023 09:37AM

Accepted by sc...@google.com.

jo...@gmail.com <jo...@gmail.com> #6Dec 12, 2023 09:21AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e6ce39f90140f19068852a99713e19680ff20559
Author: Ian Lake <ilake@google.com>
Date: Wed Jul 24 14:30:55 2019

Remove cancelled postponed transactions when popped

When popping a postponed fragment transaction,
remove the transaction from the list of postponed
transactions when cancelling it.

This prevents cases where we attempt to execute
the postponed transaction despite it already
being cancelled.

Test: new test passes
BUG: 138251858
Change-Id: Ie2f23923ad761a35c43df8716e46e51183dbc010

M fragment/fragment/src/androidTest/java/androidx/fragment/app/PrimaryNavFragmentTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/1090762

https://goto.google.com/android-sha1/e6ce39f90140f19068852a99713e19680ff20559

sc...@google.com <sc...@google.com> #7Dec 14, 2023 04:52AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/cherrypickHistory/all)
Created: 2019-07-24 22:38:18.725872+00:00
Changes: aosp/1090768

ap...@google.com <ap...@google.com> #8Dec 22, 2023 04:08AM

Turns out that this was actually a more serious, long standing issue with Fragments that was just exposed by more recent changes.

We'll be releasing a new 1.1.0-rc04 for Fragments with this fix and update Navigation 2.1 to depend on it.

sc...@google.com <sc...@google.com> Dec 22, 2023 06:33AM

Marked as fixed.

na...@google.com <na...@google.com> #9Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.4.0-alpha04
androidx.camera:camera-extensions:1.4.0-alpha04