Status Update
No update yet.
Comments
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Scott Nien <
Link:
Fix the issue that PreviewViewMeteringPointFactory produces wrong coordinates when effect or stream sharing is enabled.
Expand for full commit details
Fix the issue that PreviewViewMeteringPointFactory produces wrong coordinates when effect or stream sharing is enabled.
The PreviewviewMeteringPointFactory uses the PreviewRotationDegrees to transform the
coordinates. This PreviewRotationDegrees in TransformationInfo does't
reflect the sensor_orientation and the display orientation when effect
or stream sharing is enabled.
Solution :
Use getSensorToBufferTransform from TransmationInfo instead to convert the view(x,y)
to sensor (x,y) and also set the surfaceAspectRatio as the sensor size.
Bug: 345993685
RelNote: "Fixed the issue where invoking startFocusMetering with
PreviewView.getMeteringPointFactory does't get the correct sensor
coordinates when an effect is enabled or when 4 use cases are bound
(stream-sharing)."
Test: All tests in camera-view
Change-Id: I916c55d371a2c2e7de798b21080318591f099561
Files:
- M
camera/camera-core/src/main/java/androidx/camera/core/MeteringPointFactory.java - M
camera/camera-core/src/main/java/androidx/camera/core/internal/CameraUseCaseAdapter.java - M
camera/camera-view/src/androidTest/java/androidx/camera/view/PreviewViewMeteringPointFactoryDeviceTest.kt - M
camera/camera-view/src/main/java/androidx/camera/view/PreviewTransformation.java - M
camera/camera-view/src/main/java/androidx/camera/view/PreviewView.java - M
camera/camera-view/src/main/java/androidx/camera/view/PreviewViewMeteringPointFactory.java - M
camera/camera-view/src/test/java/androidx/camera/view/PreviewViewMeteringPointFactoryTest.java
Hash: 4099c75fbc3979a18c18f435fbf508ffdd4c7ab1
Date: Fri Sep 27 14:17:44 2024
dv...@gmail.com
The issue is fixed and the fix will be included in 1.4.0-rc04 and 1.4.0 stable release as well as the new alpha in 1.5.0. Thanks for reporting this issue and I am sorry for not fixing it promptly.
dv...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.4.0-rc04androidx.camera:camera-view:1.4.0-rc04
dv...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.5.0-alpha03androidx.camera:camera-view:1.5.0-alpha03
ap...@google.com
Branch: androidx-main
commit ec13e616312e4026429dfa6a86b820725f30e2be
Author: Chris Craik <ccraik@google.com>
Date: Wed Dec 06 09:59:35 2023
Fix FrameId parsing in FrameTimingMetric
Fixes: 303823815
Bug: 306235276
Test: SliceTest
Test: FrameTimingQueryTest
Relnote: "Fixed crash in FrameTimingMetric failing to parse frame id,
especially on certain OEM devices."
Change-Id: Ia24bc3c90b317252f579cc2425547f034ef96ef8
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/SliceTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/Slice.kt
dv...@gmail.com
thank you
Description
refer to first screenshot, that's drag down systemui bar, and swip back to launcher trace.
some metrics don't work FrameTimingMetric doesn't work because of the way of getting frameid from slice name is wrong.
can't control what kind of datasouces which perfetto server to record. Some datasources are added by ODM, we can't add datasource to record.
lack of web application to show result of benchmark test.
there is no community to talk each other , to slove those problems.