BottomSheetScaffold (M3) with nested scroll ignores sheetSwipeEnabled behavior [306464779]

Fixed

Bug

Status Update

No update yet.

Description

jo...@element.io

created issue #1

Oct 21, 2023 11:18AM

Jetpack Compose version: Compose BOM 2023.10.0

Jetpack Compose component used: BottomSheetScaffold (Material 3)

Android Studio Build: Build #AI-232.10072.27.2321.10977308

Kotlin version: 1.9.10

Steps to Reproduce or Code Sample to Reproduce:

Create a androidx.compose.material3.BottomSheetScaffold component.
Add a scrollable component inside `sheetContent slot (LazyColumn, Column with verticalScroll).
Set a peekHeight < the height of this scrollable component, so it actually can scroll.
Set sheetSwipeEnabled = false to prevent the dragging behavior.
Now try to scroll the peeking scrollable component. The bottom sheet will be moved instead, although sheetSwipeEnabled should prevent this.

Example code:

BottomSheetScaffold(
    sheetContent = {
        // I also tried adding a `nestedScroll` modifier here
        Column(modifier = Modifier.fillMaxWidth()) { 
            Column(
                modifier = Modifier
                    .fillMaxWidth()
                    .heightIn(max = 150.dp)
                    .verticalScroll(rememberScrollState())
            ) {
                for (item in 0..10) {
                    Text(text = "Item $item")
                }
            }
        }
    },
    sheetPeekHeight = 120.dp,
    sheetSwipeEnabled = false,
    modifier = Modifier.fillMaxSize()
) {
 // Some content here
}

This was also an issue in the M2 BottomSheetScaffold, and someone reported on an issue for that component that this one was also affected: https://issuetracker.google.com/issues/215403277#comment16

Comments

jo...@element.io <jo...@element.io> #2Oct 22, 2023 05:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023

Convert APIs using PointF to use Float instead

PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.

Also fixed bug with unclosed paths causing discontinuity at the
start/end point.

Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

se...@google.com <se...@google.com> Nov 10, 2023 05:33PM

Reassigned to ma...@google.com.

an...@gmail.com <an...@gmail.com> #3Mar 29, 2024 11:56AM

PointF was the main (possibly only) mutability issue, marking this as fixed

Message last modified on Mar 29, 2024 11:59AM

ma...@google.com <ma...@google.com> Mar 29, 2024 07:06PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #4Apr 1, 2024 04:42PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-shapes:1.0.0-alpha04

na...@google.com <na...@google.com> #5Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-alpha05
androidx.compose.material3:material3-android:1.3.0-alpha05
androidx.compose.material3:material3-desktop:1.3.0-alpha05

vo...@gmail.com <vo...@gmail.com> #6May 2, 2024 11:15AM

Comment has been deleted.

Message last modified on May 2, 2024 03:44PM

ve...@navi.com <ve...@navi.com> #7Jul 31, 2024 12:28PM