Add support for more customization of AppBars [306697446]

Fixed

Feature Request

Status Update

No update yet.

Description

bo...@google.com

created issue #1

Oct 20, 2023 06:41PM

Our app is using LargeTopAppBar, but would like more control over typography used.

More specifically, we would basically like to set the following of TwoRowsTopAppBar:

titleTextStyle = MaterialTheme.typography.displaySmall,
smallTitleTextStyle = MaterialTheme.typography.titleLarge,

Is TwoRowsTopAppBar something that could be publicly exposed?

Comments

sg...@google.com <sg...@google.com> Oct 20, 2023 07:46PM

Reassigned to ma...@google.com.

bo...@google.com <bo...@google.com> #2Oct 25, 2023 05:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023

Convert APIs using PointF to use Float instead

PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.

Also fixed bug with unclosed paths causing discontinuity at the
start/end point.

Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

sg...@google.com <sg...@google.com> Mar 15, 2024 01:20AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> #3Mar 26, 2024 05:39PM

PointF was the main (possibly only) mutability issue, marking this as fixed

bo...@google.com <bo...@google.com> #4Mar 26, 2024 06:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-shapes:1.0.0-alpha04

de...@google.com <de...@google.com> #5Dec 17, 2024 07:42PM

Similar to this request, I would like to request just that the smallTitle field of TwoRowsTopAppBar is exposed in LargeTopAppBar, defaulting to the title composable. We currently are awkwardly manually handling the transition of large to small and back based on the collapsed fraction of the scroll state, but it seems like the title/smalltitle solution is already there and probably superior.

The problem that comes up with both rows of the TwoRowsTopAppBar being set to a large title is that on large font sizes/display sizes there is far too much white space for the invisible first app bar.

sg...@google.com <sg...@google.com> Jan 3, 2025 10:38PM

Accepted by sg...@google.com.

sg...@google.com <sg...@google.com> #6Jan 15, 2025 12:06AM

Marked as fixed.

Added TwoRowsTopAppBar API here.

This should allow more flexibility when creating top app bars with two rows. We also previous made changes to support larger fonts in the app bars, so those changes should cover the rest of the request here (I hope :)).

Please let us know if you hit any issues.

na...@google.com <na...@google.com> #7Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha07
androidx.compose.material3:material3-android:1.4.0-alpha07
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha07
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha07

ap...@google.com <ap...@google.com> #8Feb 10, 2025 10:14PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3478344

Update the TwoRowsTopAppBar API

Expand for full commit details

Update the TwoRowsTopAppBar API 
 
- Update the API to the feedback from the API council. 
- Remove the `expanded` lambda parameter and have a separate params for 
  the expanded and collapsed heights. 
 
Test: Updated 
Bug: 306697446 
Bug: 229134133 
Bug: 268068946 
Fixes: 394144086 
Relnote: "Updates to the TowRowsTopAppBar API. We removed the `expanded` 
lambda parameters and added separate parameters for the expanded and 
collapsed heights." 
 
Change-Id: Idd6777bc381871b9e77c040762c6bca7355cda8a

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt

Hash: e414ed68307128f55615f1e482bee2212677098c
Date: Thu Feb 06 13:54:36 2025