Add support for more customization of AppBars [306697446]

Fixed

Feature Request

Status Update

No update yet.

Description

bo...@google.com

created issue #1

Oct 20, 2023 06:41PM

Our app is using LargeTopAppBar, but would like more control over typography used.

More specifically, we would basically like to set the following of TwoRowsTopAppBar:

titleTextStyle = MaterialTheme.typography.displaySmall,
smallTitleTextStyle = MaterialTheme.typography.titleLarge,

Is TwoRowsTopAppBar something that could be publicly exposed?

Comments

sg...@google.com <sg...@google.com> Oct 20, 2023 07:46PM

Reassigned to ma...@google.com.

bo...@google.com <bo...@google.com> #2Oct 25, 2023 05:35PM

I cannot repro this exactly do you need?

var isRefreshing by rememberSaveable { mutableStateOf(false) }

I think my latest change helps with these kind of issues too

https://android-review.googlesource.com/3235709

But It hasn't been released yet.

Any chance you can upload the full sample on github, so I can double check?

sg...@google.com <sg...@google.com> Mar 15, 2024 01:20AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> #3Mar 26, 2024 05:39PM

deleted

bo...@google.com <bo...@google.com> #4Mar 26, 2024 06:24PM

Hi,

Here is full sample https://github.com/jukov/PullToRefreshBug

de...@google.com <de...@google.com> #5Dec 17, 2024 07:42PM

Thanks I think I was able to identify the issue and a potential fix

sg...@google.com <sg...@google.com> Jan 3, 2025 10:38PM

Accepted by sg...@google.com.

sg...@google.com <sg...@google.com> #6Jan 15, 2025 12:06AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f1515ea14143b5754df3dcbcb47537eee49c30f2
Author: Mariano Martin <ymarian@google.com>
Date: Thu Sep 05 13:12:04 2024

[PullToRefresh] Fix issue where graphics layer doesnt invalidate

Test: tested manually that now graphics layer invalidates, in some edge cases
where pullToRefresh is used in fragments

Bug: 356039090

Change-Id: Ib80663f6dcf2f7f05bda4189b0931ee697230698

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pulltorefresh/PullToRefresh.kt

https://android-review.googlesource.com/3256138

na...@google.com <na...@google.com> #7Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha01
androidx.compose.material3:material3-android:1.4.0-alpha01

ap...@google.com <ap...@google.com> #8Feb 10, 2025 10:14PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Mariano Martin <ymarian@google.com>
Link: https://android-review.googlesource.com/3361967

[WideNavigationRail] API Feedback

Expand for full commit details

[WideNavigationRail] API Feedback 
 
Update State classes to use booleans, and current/target value. 
Change expect/actual properties constructor. 
 
Test: existing tests 
Relnote: Change WideNavigationRailState to have current/target value, remove enums in favor of boolean. 
Bug:  356039090 
 
Change-Id: Idfa29aad7efd1d0e943bf175f5bcb1fc347fdf0e

Files:

M compose/material3/benchmark/src/androidTest/java/androidx/compose/material3/benchmark/NavigationRailBenchmark.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/NavigationRailSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalWideNavigationRailScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalWideNavigationRailTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/WideNavigationRailScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/WideNavigationRailTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/WideNavigationRail.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WideNavigationRail.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WideNavigationRailState.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/WideNavigationRail.commonStubs.kt

Hash: 724c3f7eb85d05c92ce724d5c529f579d771edd4
Date: Mon Nov 18 13:19:35 2024