Add support for more customization of AppBars [306697446]

Fixed

Feature Request

Status Update

No update yet.

Description

bo...@google.com

created issue #1

Oct 20, 2023 06:41PM

Our app is using LargeTopAppBar, but would like more control over typography used.

More specifically, we would basically like to set the following of TwoRowsTopAppBar:

titleTextStyle = MaterialTheme.typography.displaySmall,
smallTitleTextStyle = MaterialTheme.typography.titleLarge,

Is TwoRowsTopAppBar something that could be publicly exposed?

Comments

sg...@google.com <sg...@google.com> Oct 20, 2023 07:46PM

Reassigned to ma...@google.com.

bo...@google.com <bo...@google.com> #2Oct 25, 2023 05:35PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

sg...@google.com <sg...@google.com> Mar 15, 2024 01:20AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> #3Mar 26, 2024 05:39PM

Thanks for the report!

bo...@google.com <bo...@google.com> #4Mar 26, 2024 06:24PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

de...@google.com <de...@google.com> #5Dec 17, 2024 07:42PM

deleted

sg...@google.com <sg...@google.com> Jan 3, 2025 10:38PM

Accepted by sg...@google.com.

sg...@google.com <sg...@google.com> #6Jan 15, 2025 12:06AM

Marked as fixed.

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

na...@google.com <na...@google.com> #7Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha07
androidx.compose.material3:material3-android:1.4.0-alpha07
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha07
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha07

ap...@google.com <ap...@google.com> #8Feb 10, 2025 10:14PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3478344

Update the TwoRowsTopAppBar API

Expand for full commit details

Update the TwoRowsTopAppBar API 
 
- Update the API to the feedback from the API council. 
- Remove the `expanded` lambda parameter and have a separate params for 
  the expanded and collapsed heights. 
 
Test: Updated 
Bug: 306697446 
Bug: 229134133 
Bug: 268068946 
Fixes: 394144086 
Relnote: "Updates to the TowRowsTopAppBar API. We removed the `expanded` 
lambda parameters and added separate parameters for the expanded and 
collapsed heights." 
 
Change-Id: Idd6777bc381871b9e77c040762c6bca7355cda8a

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt

Hash: e414ed68307128f55615f1e482bee2212677098c
Date: Thu Feb 06 13:54:36 2025