Benchmarks - Regression found between 10992010 and 10992745 [307445225]

Fixed

Bug

Status Update

No update yet.

Description

sk...@skia-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 24, 2023 03:36AM

Perf Regression (High) found, matching 284 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Tests affected:

 androidx.compose.foundation.benchmark.ScrollerBenchmark_draw
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_modifiersOnly_update_draw
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_modifiersOnly_update_recompose
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_redrawOnly_first_layout
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_redrawOnly_first_measure
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_twoLayoutNodes_first_measure
 androidx.compose.foundation.benchmark.TrailingLambdaBenchmark_withTrailingLambdas_recompose
 androidx.compose.foundation.benchmark.lazy.LazyListScrollingBenchmark_drawAfterScroll_newItemComposed_LazyColumn_
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_modifier_draw
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_modifier_layout
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_modifier_togglePadding_recompose
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_noModifier_first_draw
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_noModifier_togglePadding_layout
 androidx.compose.foundation.layout.benchmark.RectsInColumnBenchmark_layout_10_
 androidx.compose.material.benchmark.CheckboxesInRowsBenchmark_draw_10_
 androidx.compose.material.benchmark.CheckboxesInRowsBenchmark_draw_1_
 androidx.compose.material.benchmark.CheckboxesInRowsBenchmark_toggleCheckbox_measure_1_
 androidx.compose.material.benchmark.RadioGroupBenchmark_toggleRadio_draw
 androidx.compose.ui.OnPositionedBenchmark_deepHierarchyOnPositioned_layout
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuseHoisted_emptyElement_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuse_Modifier_10x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuse_clickable_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuse_emptyElement_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_base_emptyElement_100x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_fullReuseHoisted_Modifier_10x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_fullReuseHoisted_emptyElement_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_fullReuse_Modifier_10x_
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_cached_fontFamily_FontFamily.Default_fontWeight_FontWeight_weight_100__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_cached_fontFamily_FontFamily.Serif_fontWeight_FontWeight_weight_100__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_cached_fontFamily_FontFamily.Serif_fontWeight_FontWeight_weight_700__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_forceUncached_fontFamily_FontFamily.Cursive_fontWeight_FontWeight_weight_700__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_forceUncached_fontFamily_FontFamily.Default_fontWeight_FontWeight_weight_400__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_forceUncached_fontFamily_FontFamily.Monospace_fontWeight_FontWeight_weight_400__
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Long_Text__senario_Cursor_movement_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Long_Text__senario_Delete_text_in_code_points_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Long_Text__senario_Set_composition_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Short_Text__senario_Insert_composition_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Short_Text__senario_Set_composition_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannableStringBuilder_size_1_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_size_1_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_size_20_replaceAll_true_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_withExistingEmojiSpans_size_10_replaceAll_true_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_withExistingEmojiSpans_size_20_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiString_size_10_replaceAll_true_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiString_size_1_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_latin_size_40_replaceAll_true_
 androidx.room.benchmark.AmbiguousColumnResolverBenchmark_largeResolution_numOfColumns_50__numOfTables_2__numOfDupes_2_
 androidx.wear.compose.material.benchmark.StepperBenchmark_draw
 androidx.wear.compose.material.benchmark.StepperBenchmark_layout

Devices affected:

 sargo

Comments

an...@google.com <an...@google.com> Oct 25, 2023 05:30PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #2Oct 25, 2023 10:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@google.com <ma...@google.com> Oct 25, 2023 10:56PM

Marked as fixed.

cc...@google.com <cc...@google.com> Jul 26, 2024 10:44PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #3Jul 27, 2024 12:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit 5de09686debf78730da51df37c78f91e77d3dbc5
Author: Chris Craik <ccraik@google.com>
Date: Fri Jul 26 15:30:55 2024

Fix pause/resume ordering to preserve metric priority

Test: MetricsContainerTest#validatePriorityOrder
Bug: 286306579
Bug: 307445225

Relnote: "Fix resumeTiming/runWithTimingDisabled to respect metric
priority order, and significantly reduce impact of lower priority
metric pause/resume on higher priority metric results. For example, if
using cpu perf counters via `cpuEventCounter.enable` instrumentation
argument, timeNs is no longer significantly reduced when pause/resume
occur."

Drastically reduces impact of perf event counters on timeNs measurements

-- Baseline, perf counters disabled -- (here and below running on mokey 32 bit, jit disabled)
136,714 ns 11 allocs Trace LazyListScrollingBenchmark.drawAfterScroll_newItemComposed[LazyColumn]

-- Before Change, perf counters enabled --
LazyListScrollingBenchmark.drawAfterScroll_newItemComposed[LazyColumn]
timeNs min 172,242.6, median 185,443.2, max 216,688.5
Instructions min 87,728.2, median 88,600.8, max 93,946.2
CpuCycles min 145,951.4, median 151,045.5, max 174,344.5
allocationCount min 11.0, median 11.0, max 11.0

-- After Change, perf counters enabled --
LazyListScrollingBenchmark.drawAfterScroll_newItemComposed[LazyColumn]
timeNs min 140,890.3, median 149,411.4, max 199,267.2
Instructions min 87,940.5, median 89,342.1, max 95,317.8
CpuCycles min 146,792.6, median 152,793.3, max 180,540.3
allocationCount min 11.0, median 11.0, max 11.0

Change-Id: I39c2eb911129927972740d074ee8f2adca7bda1a

M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MetricsContainerTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/MetricsContainer.kt

https://android-review.googlesource.com/3197014

ap...@google.com <ap...@google.com> #4Aug 2, 2024 11:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit 992cb25c28026d5f259edb7459f6d7c6be43ce34
Author: Chris Craik <ccraik@google.com>
Date: Fri Jul 26 15:59:45 2024

Reapply "Fixed tests and added measure api to CpuEventCounter"

Bug: 286306579
Bug: 307445225
Test: AndroidTestConfigBuilderTest

Reenables microbenchmark cpu counters in CI, now that intrusiveness
has been addressed.

This reverts commit 698248c877020adb675fd30becc55551e8ffc281.

Change-Id: I024f82907805d54eaf98c9233c1766e79a1b5dfd

M buildSrc-tests/src/test/java/androidx/build/testConfiguration/AndroidTestConfigBuilderTest.kt
M buildSrc/private/src/main/kotlin/androidx/build/testConfiguration/AndroidTestConfigBuilder.kt

https://android-review.googlesource.com/3195021

cc...@google.com <cc...@google.com> Sep 27, 2024 09:09PM