Benchmarks - Regression found between 10992010 and 10992745 [307445225]

Fixed

Bug

Status Update

No update yet.

Description

sk...@skia-public.iam.gserviceaccount.com

created issue on behalf of an...@google.com #1

Oct 24, 2023 03:36AM

Perf Regression (High) found, matching 284 tracked metrics from benchmarks.

To triage this regression, see the guide at go/androidx-bench-triage.

Tests affected:

 androidx.compose.foundation.benchmark.ScrollerBenchmark_draw
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_modifiersOnly_update_draw
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_modifiersOnly_update_recompose
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_redrawOnly_first_layout
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_redrawOnly_first_measure
 androidx.compose.foundation.benchmark.SimpleComponentImplementationBenchmark_component_twoLayoutNodes_first_measure
 androidx.compose.foundation.benchmark.TrailingLambdaBenchmark_withTrailingLambdas_recompose
 androidx.compose.foundation.benchmark.lazy.LazyListScrollingBenchmark_drawAfterScroll_newItemComposed_LazyColumn_
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_modifier_draw
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_modifier_layout
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_modifier_togglePadding_recompose
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_noModifier_first_draw
 androidx.compose.foundation.layout.benchmark.PaddingBenchmark_noModifier_togglePadding_layout
 androidx.compose.foundation.layout.benchmark.RectsInColumnBenchmark_layout_10_
 androidx.compose.material.benchmark.CheckboxesInRowsBenchmark_draw_10_
 androidx.compose.material.benchmark.CheckboxesInRowsBenchmark_draw_1_
 androidx.compose.material.benchmark.CheckboxesInRowsBenchmark_toggleCheckbox_measure_1_
 androidx.compose.material.benchmark.RadioGroupBenchmark_toggleRadio_draw
 androidx.compose.ui.OnPositionedBenchmark_deepHierarchyOnPositioned_layout
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuseHoisted_emptyElement_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuse_Modifier_10x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuse_clickable_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_baseReuse_emptyElement_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_base_emptyElement_100x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_fullReuseHoisted_Modifier_10x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_fullReuseHoisted_emptyElement_1x_
 androidx.compose.ui.benchmark.ModifiersBenchmark_fullReuse_Modifier_10x_
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_cached_fontFamily_FontFamily.Default_fontWeight_FontWeight_weight_100__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_cached_fontFamily_FontFamily.Serif_fontWeight_FontWeight_weight_100__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_cached_fontFamily_FontFamily.Serif_fontWeight_FontWeight_weight_700__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_forceUncached_fontFamily_FontFamily.Cursive_fontWeight_FontWeight_weight_700__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_forceUncached_fontFamily_FontFamily.Default_fontWeight_FontWeight_weight_400__
 androidx.compose.ui.text.benchmark.font.PlatformFontLookup_forceUncached_fontFamily_FontFamily.Monospace_fontWeight_FontWeight_weight_400__
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Long_Text__senario_Cursor_movement_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Long_Text__senario_Delete_text_in_code_points_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Long_Text__senario_Set_composition_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Short_Text__senario_Insert_composition_
 androidx.compose.ui.text.benchmark.input.EditProcessorBenchmark_scenarioTest_initText_Short_Text__senario_Set_composition_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannableStringBuilder_size_1_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_size_1_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_size_20_replaceAll_true_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_withExistingEmojiSpans_size_10_replaceAll_true_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiSpannedString_withExistingEmojiSpans_size_20_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiString_size_10_replaceAll_true_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_emojiString_size_1_replaceAll_false_
 androidx.emoji2.benchmark.text.EmojiProcessBenchmark_latin_size_40_replaceAll_true_
 androidx.room.benchmark.AmbiguousColumnResolverBenchmark_largeResolution_numOfColumns_50__numOfTables_2__numOfDupes_2_
 androidx.wear.compose.material.benchmark.StepperBenchmark_draw
 androidx.wear.compose.material.benchmark.StepperBenchmark_layout

Devices affected:

 sargo

Comments

an...@google.com <an...@google.com> Oct 25, 2023 05:30PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #2Oct 25, 2023 10:40PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ma...@google.com <ma...@google.com> Oct 25, 2023 10:56PM

Marked as fixed.

cc...@google.com <cc...@google.com> Jul 26, 2024 10:44PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #3Jul 27, 2024 12:06AM

yea i'll take it.

ap...@google.com <ap...@google.com> #4Aug 2, 2024 11:38PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

cc...@google.com <cc...@google.com> Sep 27, 2024 09:09PM