Adding baselineprofile module feature break settings.gradle [307473787]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Oct 24, 2023 04:41PM

DESCRIBE THE ISSUE IN DETAIL:
I tried to follow https://developer.android.com/topic/performance/baselineprofiles/create-baselineprofile#create-new-profile

STEPS TO REPRODUCE:
1.Clone https://github.com/ganadist/VersionCodeDemo

$ git clone https://github.com/ganadist/VersionCodeDemo -b baselineprofile1
$ cd VersionCodeDemo
$ git checkout HEAD~1

Open Android Studio Iguana Canary 9
Select menu: File -> New -> New Module -> Baseline Profile Generator
Generated codes are https://github.com/ganadist/VersionCodeDemo/commit/1dce284ea2b5590476f7ff448c4b2c6289604b12
Perform gradle and build was failed.

./gradlew :app:assembleDevelopDebug
Configuration on demand is an incubating feature.

FAILURE: Build failed with an exception.

* Where:
Settings file '/home/ganadist/src/build/AndroidStudioProjects/VersionCodeDemo/settings.gradle' line: 9

* What went wrong:
A problem occurred evaluating settings 'VersionCodeDemo'.
> Could not get unknown property 'libs' for object of type org.gradle.plugin.management.internal.DefaultPluginManagementSpec$PluginDependenciesSpecImpl.

CONTEXT:
Android Studio added several plugins with Gradle Version Catalog like this on settings.gradle. But, Gradle does not allow to use Version Catalog on settings.gradle
https://github.com/gradle/gradle/issues/24876#issuecomment-1519674615

Plugin declarations with Version Catalogs should be added on build.gradle of root project instead of settings.gradle

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Iguana Canary 9
Version of Gradle Plugin: 8.2.0-rc01
Version of Gradle: 8.4
Version of Java: OpenJDK 17
OS: Any

Comments

ma...@google.com <ma...@google.com> Oct 24, 2023 09:19PM

Assigned to ma...@google.com.

ag...@google.com <ag...@google.com> Oct 25, 2023 11:03AM

Reassigned to an...@google.com.

ma...@google.com <ma...@google.com> Oct 25, 2023 04:52PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Oct 25, 2023 09:25PM

Plugin declarations with Version Catalogs should be added on build.gradle of root project instead of settings.gradle

I tested on a new project and this should already be the case. I'm wondering if the custom build logic in that project "confuses" the template generator.

In any case will make sure to report this to AS team to make sure this is correct.

Thanks for reporting.

ma...@google.com <ma...@google.com> Oct 27, 2023 05:30PM

Marked as fixed.

Issue 307473787