baselineprofile gradle plugin is not work properly. [307478189]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Oct 24, 2023 04:57PM

Continuing report from b/307473787

I tried to follow https://developer.android.com/topic/performance/baselineprofiles/create-baselineprofile#create-new-profile

And applied androidx.baselineprofile gradle plugin on my project.

But when I tried to perform gradle, and gradle failed like this.

$ git clone https://github.com/ganadist/VersionCodeDemo -b baselineprofile2
$ cd VersionCodeDemo
$ ./gradlew :app:tasks -S

...

Caused by: org.gradle.api.UnknownTaskException: Task with name 'mergeBetaBenchmarkReleaseArtProfile' not found in project ':app'.
	at org.gradle.api.internal.tasks.DefaultTaskCollection.createNotFoundException(DefaultTaskCollection.java:102)
	at org.gradle.api.internal.tasks.DefaultTaskCollection.createNotFoundException(DefaultTaskCollection.java:46)
	at org.gradle.api.internal.DefaultNamedDomainObjectCollection.named(DefaultNamedDomainObjectCollection.java:361)
	at org.gradle.api.internal.tasks.DefaultTaskCollection.named(DefaultTaskCollection.java:112)
	at androidx.baselineprofile.gradle.consumer.BaselineProfileConsumerAgpPlugin$onVariants$lastTaskProvider$applySourceSetsFunc$1.invoke(BaselineProfileConsumerPlugin.kt:336)
	at androidx.baselineprofile.gradle.consumer.BaselineProfileConsumerAgpPlugin$onVariants$lastTaskProvider$applySourceSetsFunc$1.invoke(BaselineProfileConsumerPlugin.kt:333)
	at androidx.baselineprofile.gradle.consumer.BaselineProfileConsumerAgpPlugin$onVariants$lastTaskProvider$2.invoke(BaselineProfileConsumerPlugin.kt:356)
	at androidx.baselineprofile.gradle.consumer.BaselineProfileConsumerAgpPlugin$onVariants$lastTaskProvider$2.invoke(BaselineProfileConsumerPlugin.kt:349)
	at androidx.baselineprofile.gradle.utils.AgpPlugin$configureWithAndroidPlugin$5.invoke(AgpPlugin.kt:169)
	at androidx.baselineprofile.gradle.utils.AgpPlugin$configureWithAndroidPlugin$5.invoke(AgpPlugin.kt:164)
	at androidx.baselineprofile.gradle.utils.AgpPlugin.configureWithAndroidPlugin$lambda$6(AgpPlugin.kt:164)
	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:123)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction$1.run(DefaultCollectionCallbackActionDecorator.java:110)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:47)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:73)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction.execute(DefaultCollectionCallbackActionDecorator.java:107)
	at org.gradle.internal.ImmutableActionSet$SetWithFewActions.execute(ImmutableActionSet.java:285)
	at org.gradle.api.internal.DefaultDomainObjectCollection.doAdd(DefaultDomainObjectCollection.java:262)
	at org.gradle.api.internal.DefaultDomainObjectCollection.add(DefaultDomainObjectCollection.java:251)
	at com.android.build.gradle.AbstractAppExtension.addVariant(AbstractAppExtension.kt:64)
	at com.android.build.gradle.internal.ApiObjectFactory.create(ApiObjectFactory.java:126)

Component used:

Gradle : 8.4
Android Gradle Plugin: 8.2.0-rc01
Java: OpenJDK 17
Androidx Benchmark / Baseline Profile Plugin : 1.2.0

Devices/Android versions reproduced on: N/A

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

Comments

cc...@google.com <cc...@google.com> Oct 24, 2023 05:00PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Oct 24, 2023 09:19PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> #2Oct 25, 2023 09:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ga...@linecorp.com <ga...@linecorp.com> #3Oct 26, 2023 01:30AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ga...@linecorp.com <ga...@linecorp.com> #4Oct 26, 2023 04:02AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ga...@linecorp.com <ga...@linecorp.com> #5Oct 26, 2023 09:43AM

I added this logic to allow build types which are added by baselineprofile plugin.
https://github.com/ganadist/VersionCodeDemo/commit/efe2fd48a3

As I commented at #3 , variants filtering would be used widely.
So, https://developer.android.com/topic/performance/baselineprofiles/create-baselineprofile page should have information about added build type from plugin, and mention should be added not to ignore these build type.

Or please raise exception which has these information instead of UnknownTaskException

ma...@google.com <ma...@google.com> #6Oct 26, 2023 04:43PM

But filtering variants feature is introduced at https://developer.android.com/build/build-variants#filter-variants, and It is expected to be widely used.

Unfortunately, the plugin cannot prevent the user to disable a variant that is used for baseline profile generation. This is because build types are created in finalizeDsl, while variants can be disabled in beforeVariants that runs after. There are actually some hacky way to do this but supporting them would require api that are currently deprecated and not meant for public use (that means AGP can break them any time).

Improving the error message is already on my to-do list and will pass the task to the team to update the documentation.

Thank you for trying the baseline profile gradle plugin, if you encounter any other issue please don't hesitate to reach out.

ap...@google.com <ap...@google.com> #7Nov 9, 2023 07:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0a3e9f8ceef5cb0ceffc8385346f45e86985f0aa
Author: Marcello Albano <maralb@google.com>
Date: Thu Oct 26 10:32:53 2023

Improved error msg when benchmark variants are disabled

Bug: 307478189
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Change-Id: I8536bc3c14bbf2d1ee165b3d3f55a3dec9ff61d7

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt

https://android-review.googlesource.com/2806414

pr...@google.com <pr...@google.com> #8Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-alpha01