Status Update
No update yet.
Comments
mo...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
mo...@google.com
mo...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
mo...@google.com
Passing to Jeremy to get his thoughts
jb...@google.com
What we really need is a signal to say when all transitions are done and with it running early, we don't have that. For fragments this means that we could end up moving the fragment to RESUMED before all the transitions are actually completed and execute some code that is normally fine when the system is settled, but dangerous when it is not.
If moving onTransitionEnd() might be too dangerous are there other options? If you are in the animateToStart case should you even get an onTransitionEnd(). Maybe all external listeners get is an onTransitionCancel() since you are reversing a transition you started in the middle of it. Is that a safer signal to send back?
I think it is okay to separate the signals as long as they are explicit, but we for sure need a way to know that the Transition system is completely done doing any work and our Views are back in the original state that we passed them in.
mo...@google.com
Maybe you could notify at the end of your animateToStart lambda?
jb...@google.com
Per offline discussion, we can move ahead with the solution suggested in
This will change the current order:
start transition > animateToStart > onTransitionEnd() > Runnable > finish up transition work
to
start transition > animateToStart > Runnable > finish up transition work > onTransitionEnd()
This has the implications that if developers are doing something with a specific result in their onTransitionEnd() callback, they will also need to handle the cancellation case by overriding the new onTransitionEnd(Transition, boolean)
For example, if there is a transition from View_A to View_B and the onTransitionEnd() callback has logic that expects View_B to be the final state, it will now need to add some additional logic based on the boolean in the case that View_A is the final state.
mo...@google.com
ap...@google.com
Branch: androidx-main
commit 889b310dee76183e0f89e76d014728f728190740
Author: George Mount <mount@google.com>
Date: Wed Dec 20 14:35:35 2023
Change order of listeners for seeking transitions.
Fixes: 307624554
When TransitionSeekController.animateToStart() is used,
externally added TransitionListeners will have onTransitionEnd()
called after the animateToStart()'s lambda. Internally-added
listeners will be called before the animateToStart()'s lambda.
Test: new test
Change-Id: Ic6a55916958f85d41c54d7739bde09cfc2352d7c
M transition/transition/src/androidTest/java/androidx/transition/SeekTransitionTest.kt
M transition/transition/src/main/java/androidx/transition/Transition.java
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.transition:transition:1.5.0-alpha06
Description
Component used: Transition
Version used: 1.5.0-alpha04
Expected:
When using the new
animateToStart(Runnable)API, I would expect the Runnable to be executed before anyonTransitionEnd()callback that were set on the transition that was being seeked.Actual:
The logs execute inside the
onTransitionEnd()callback before the runnable.Steps:
1a. Use predictive back and cancel the gesture
1b. Launch the app and click the "Animate" button, then click the "Cancel Animation" button