R8 stuck in BridgeAnalyzer.analyzeMethod [307761442]

Fixed

Bug

Status Update

No update yet.

Description

to...@xperi.com

created issue #1

Oct 25, 2023 07:00PM

Since a relatively recent change, R8 never finishes processing in one of the projects I work on. It is an Android project using roughly the same machinery as the Chromium build, so I'm working with a direct java ... -cp r8.jar-style call, but I'm currently unable to share a reproducer test case (proprietary code and issue not minimized). I'm not sure why this only reproduces in this one project, and not elsewhere.

I do have a jstack dump of when it's stuck (attached), and managed to bisect the issue in r8 to a change in the function where the code gets stuck. I hope that's enough to start looking.

The relevant-looking stack is

"ForkJoinPool-1-worker-6" #31 daemon prio=5 os_prio=0 cpu=49610,08ms elapsed=65,58s tid=0x00007f44748b9a90 nid=0x24ba22 runnable  [0x00007f435b1e6000]
   java.lang.Thread.State: RUNNABLE
        at com.android.tools.r8.ir.optimize.info.bridge.BridgeAnalyzer.analyzeMethod(BridgeAnalyzer.java:99)
        - parking to wait for  <0x0000000080b1af88> (a java.util.concurrent.ForkJoinPool)
        at com.android.tools.r8.ir.optimize.info.MethodOptimizationInfoCollector.identifyBridgeInfo(MethodOptimizationInfoCollector.java:165)
        at com.android.tools.r8.ir.optimize.info.MethodOptimizationInfoCollector.collectMethodOptimizationInfo(MethodOptimizationInfoCollector.java:142)

and the bisect pointed to https://r8.googlesource.com/r8/+/3c21ca42d6450665b9bdb3ef0872a3b1ca744ac5 which modifies BridgeAnalyzer.analyzeMethod.

I'm not familiar with this code at all but it looks like it could be possible to never exit the while loop in some gotoInstruction edge case after this change. The problem still exist in r8's main branch as of today.

r8-stuck-jstack.txt

20 KB

View

Download

Comments

sg...@google.com <sg...@google.com> #2Oct 26, 2023 06:47AM

Reassigned to sg...@google.com.

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

to...@xperi.com <to...@xperi.com> #3Oct 26, 2023 07:57AM

Almost 2 months later and this is still broken

sg...@google.com <sg...@google.com> #4Oct 26, 2023 02:33PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

ch...@google.com <ch...@google.com> Oct 30, 2023 08:06AM

Reassigned to ch...@google.com.

to...@xperi.com <to...@xperi.com> #5Oct 30, 2023 08:54AM

jb...@google.com What is the update on this?

Message last modified on Oct 30, 2023 08:55AM

ap...@google.com <ap...@google.com> #6Oct 30, 2023 10:02AM

What is the status of this item?

ch...@google.com <ch...@google.com> #7Oct 30, 2023 10:06AM

Marked as fixed.

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

ap...@google.com <ap...@google.com> #8Oct 30, 2023 10:25AM

Any ETA on next release?

ap...@google.com <ap...@google.com> #9Oct 30, 2023 10:25AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ch...@google.com <ch...@google.com> #10Oct 30, 2023 10:27AM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

to...@xperi.com <to...@xperi.com> #11Oct 30, 2023 10:50AM

Hi, is there any update to this issue? Thanks.

sg...@google.com <sg...@google.com> #12Oct 30, 2023 11:20AM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

an...@google.com <an...@google.com> #13Jan 3, 2024 06:01PM

Yeah, still not fixed --'