BuildType#initWith copies postprocessing block but proguard configuration is not applied [307784512]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Oct 26, 2023 10:15AM

Continuing report from b/307473787

I tried to follow https://developer.android.com/topic/performance/baselineprofiles/create-baselineprofile#create-new-profile

I tried to perform testcases which are generated by baseline profile generator on Android Studio.
And tests are failed, because proguard rule was not installed on benchmarkRelease build type.

In my case, there are several dontwarn rules, because many 3rd party libraries references missing classes.

$ git clone https://github.com/ganadist/VersionCodeDemo -b baselineprofile3

$ cd VersionCodeDemo
$ grep -C1 SuppressViolation app/proguard-rules.pro 
# referenced from: void com.google.android.payments.standard.StandardPaymentsUtils.verifyCallingAppIsGoogleSigned(android.content.Context, java.lang.String, boolean))
-dontwarn com.google.apps.tiktok.testing.errorprone.SuppressViolation

$ ./gradlew :app:assembleProductionRelease

$ grep -C1 SuppressViolation app/build/outputs/mapping/productionRelease/configuration.txt
# referenced from: void com.google.android.payments.standard.StandardPaymentsUtils.verifyCallingAppIsGoogleSigned(android.content.Context, java.lang.String, boolean))
-dontwarn com.google.apps.tiktok.testing.errorprone.SuppressViolation

$ ./gradlew :app:assembleProductionBenchmarkRelease

$ grep -C1 SuppressViolation app/build/outputs/mapping/productionBenchmarkRelease/configuration.txt

It seems that benchmarkRelease build type should be inherited proguard rules from release build type.

Component used: Androidx Benchmark/baselineprofile plugin 1.2.0

Comments

ga...@linecorp.com <ga...@linecorp.com> #2Oct 26, 2023 10:21AM

for example, many different devices return the same longitude and latitude.such as : longitude is 121.474000 and latitude is 31.230001.
i donnot understand why is the data the same?

ga...@linecorp.com <ga...@linecorp.com> #3Dec 21, 2023 12:34AM

the fractional part of the location data is exactly the same.

be...@google.com <be...@google.com> Dec 21, 2023 08:47AM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #4Dec 21, 2023 05:33PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. AP4A.241205.013.A1)

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

ma...@google.com <ma...@google.com> Apr 17, 2024 06:12PM

Accepted by ma...@google.com.

ma...@google.com <ma...@google.com> #5Apr 17, 2024 10:20PM

Marked as fixed.

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

ap...@google.com <ap...@google.com> #6Apr 17, 2024 11:50PM

I only aply permission android.permission.ACCESS_COARSE_LOCATION.I use android.location.Location in the program.
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。

as for Android build,all versions have it.
I dont reprodouce this issue.

what may be the cause of this issue?please

ga...@linecorp.com <ga...@linecorp.com> #7Apr 18, 2024 03:54AM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

ma...@google.com <ma...@google.com> #8Apr 18, 2024 04:52PM

Thanks for reporting this issue.

COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.

Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.

ma...@google.com <ma...@google.com> #9Apr 18, 2024 05:31PM

Status: Assigned (reopened)

We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.

Message last modified on Apr 18, 2024 05:53PM

ma...@google.com <ma...@google.com> #10Apr 18, 2024 06:28PM

Thank you very much! it is very useful to me . It solved my confusion.

Message last modified on Apr 18, 2024 06:29PM

cc...@google.com <cc...@google.com> #11Apr 18, 2024 07:31PM

Reassigned to je...@google.com.

Over to AGP with improved repro

ja...@gmail.com <ja...@gmail.com> #12Aug 18, 2024 10:23AM

Any update on this one?

It still affects the Baseline Profiles integration (building the benchmarkRelease) in projects where release.postprocessing is used. Both AGP 8.5.2 and 8.6.0-rc01 seem to have this issue.

je...@google.com <je...@google.com> Aug 19, 2024 05:48AM

Reassigned to mi...@google.com.

mi...@google.com <mi...@google.com> Aug 20, 2024 06:10PM

Accepted by mi...@google.com.

mi...@google.com <mi...@google.com> #13Aug 26, 2024 05:01PM

Marked as fixed.

This has been fixed in https://android.googlesource.com/platform/tools/base/+/08356be7b624ad785f01b390554b80b14838229f and will target AGP 8.7.0-alpha09.

ja...@gmail.com <ja...@gmail.com> #14Aug 26, 2024 05:09PM

Looking forward to try the fix.

Will it be backported to AGP 8.6.x or 8.5.x?

an...@google.com <an...@google.com> #15Aug 30, 2024 02:21PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug | 2024.2.1 Canary 9
Android Gradle Plugin 8.7.0-alpha09

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!