Status Update
Comments
xo...@google.com <xo...@google.com> #2
I can reproduce this (thanks for the repro project!)
It looks like the problem is that the desugared api list from r8 contains this entry:
java/util/Collection#removeIf(Ljava/util/function/Predicate;)Z
but the bytecode here doesn't match -- it's java/util/ArrayList. Collection isn't a directly implemented interface or a direct super class, it's an interface on the super super class. The most efficient thing runtime wise would be for the signature list to inline this method on all implemented subclasses. But I should probably at least for now go and make the desugared API lookup do something similar to what it does for API lookup -- search through all super classes and interfaces as well. This isn't a new problem, so I'm very surprised this hasn't come up before (or it has, and I've forgotten).
er...@google.com <er...@google.com>
xo...@google.com <xo...@google.com>
an...@google.com <an...@google.com> #3
(I have a pending CL that was working to improve the handling of fields now that r8 handles desugaring fields, I'll try to dust that off and combine the fix in there.)
Description
The
UnusedResourcesProcessor
for removing unused resources from the project might be informed (from Lint) that there is an issue related to a Gradle build file.If that Gradle build file is in a directory whose name is equal to one of the
ResourceFolderType
names, or which begins with one of those names followed by a hyphen, theUnusedResourcesProcessor
will delete the Gradle build file rather than removing the appropriateresValues
entry. (This is becausegetFolderType()
will somewhat spuriously return aResourceFolderType
rather thannull
).