DexArchiveBuilderTaskDelegate was failed with resource only library module [308401803]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Oct 30, 2023 11:57PM

DESCRIBE THE ISSUE IN DETAIL:

I'm sorry that I cannot provide reproducible project, because this error is related with incremental build only, and hard to reproducible.

I have a large Android Project.

And there are several library modules which are not included java or kotlin sources.

Sometimes (about 1-2%) I find errors like the one below.

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:dexBuilderDevelopDebug'.
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:149)
•••

Caused by: java.lang.IllegalStateException: Reported RESOURCE_ONLY_LIB/build/intermediates/runtime_library_classes_jar/debug/classes.jar as removed. Output mapping should be non-incremental.
at com.android.build.gradle.internal.tasks.DexArchiveBuilderTaskDelegate$OutputMapping.<init>(DexArchiveBuilderTaskDelegate.kt:553)
at com.android.build.gradle.internal.tasks.DexArchiveBuilderTaskDelegate.<init>(DexArchiveBuilderTaskDelegate.kt:96)
at com.android.build.gradle.internal.tasks.DexArchiveBuilderTask.doTaskAction(DexArchiveBuilderTask.kt:194)
at com.android.build.gradle.internal.tasks.NewIncrementalTask$taskAction$$inlined$recordTaskAction$1.invoke(BaseTask.kt:69)
at com.android.build.gradle.internal.tasks.Blocks.recordSpan(Blocks.java:51)
at com.android.build.gradle.internal.tasks.NewIncrementalTask.taskAction(NewIncrementalTask.kt:46)

And it seems this exception raised at https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:build-system/gradle-core/src/main/java/com/android/build/gradle/internal/tasks/DexArchiveBuilderTaskDelegate.kt;l=553-555

After added dummy source code in resource only library, this compile errors have disappeared.

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Any
Version of Gradle Plugin: 8.0, 8.1
Version of Gradle: 8.2, 8.3, 8,4
Version of Java: OpenJDK 17
OS: Any

Comments

km...@google.com <km...@google.com> Oct 31, 2023 03:37PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Nov 2, 2023 06:12AM

Reassigned to hu...@google.com.

hu...@google.com <hu...@google.com> #2Nov 20, 2023 04:30PM

Thank you for this report!

Root cause

The existing OutputMapping computation in DexArchiveBuilderTaskDelegate ensures that the dexing task runs incrementally only if the jars' file paths are unchanged (to avoid Issue 154712997).

Given that condition, we then assert that the jars must not be reported as REMOVED. However, as shown in this bug, that assertion may sometimes still fail.

There are a few explanations:

The jar's position has changed. In that case, Gradle will report the jar as both REMOVED and ADDED. However, we have a preprocessing step in DexArchiveBuilderTask to keep the ADDED file change only, so it must be something else.
The jar is moved from one scope to another (e.g., from SUBPROJECT_SCOPE to MIXED_SCOPE). Since we get the changes per scope and the preprocessing for moved files is also done per scope, we would see the jar as REMOVED from SUBPROJECT_SCOPE and ADDED in MIXED_SCOPE. Because OutputMapping computation looks at all the scopes together, it will see the jar as both REMOVED and ADDED.
Gradle normalizes the paths when detecting changes, so it may report a file as REMOVED even though its absolute path is unchanged (see https://github.com/gradle/gradle/issues/27061).

Fix

To address this issue, we will remove the assertion as it is not strictly required. When the jar is reported as changed (regardless of whether the change is REMOVED, MODIFIED, or ADDED), we will recompute the jar's hash.

hu...@google.com <hu...@google.com> #3Nov 20, 2023 08:05PM

Marked as fixed.

Fixed in change: https://android.googlesource.com/platform/tools/base/+/9c43d75620f83b92ec026a5ce6caf6897229a1af (AGP 8.3.0-alpha15).

(Side note: The chance of hitting this issue has also been greatly reduced after we've fixed Issue 310252873.)

an...@google.com <an...@google.com> #4Nov 28, 2023 05:01PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 15
Android Gradle Plugin 8.3.0-alpha15

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ha...@gmail.com <ha...@gmail.com> #5Nov 2, 2024 10:56PM

Top