IssueTracker

Component used: androidx.preference:preference-ktx / androidx.preference:preference Version used: 1.2.1 Devices/Android versions reproduced on: all

If this is a bug in the library, we would appreciate if you could attach:

• Sample project to trigger the issue. - no sample project, but easy steps to reproduce
• A screenrecord or screenshots showing the issue (if UI related). - no recording, but observable even in the Android Studio XML layout Design view

Steps to reproduce:

• Having a simple LinearLayout with any content inside.
• The layout uses the PreferenceFragmentList.Material style.
• In the layout, we set the android:paddingStart and android:paddingEnd to 16dp (any value different than 0 repro the issue).

Expected result:

• The Left and Right paddings (in the example it does not matter if Right or Left), are set to 16dp

Current behavior:

• The paddings are set to 0dp

Observations/research

The issue was observed after upgrading the preference library from v1.0.0 to the latest v1.2.1

After a quick research, I found that several Styles were changed:

• v1.0.0

    <style name="PreferenceFragment">
        <item name="android:paddingLeft">0dp</item>
        <item name="android:paddingRight">0dp</item>
        <item name="android:divider">?android:attr/listDivider</item>
    </style>
    <style name="PreferenceFragmentList">
        <item name="android:paddingLeft">16dp</item>
        <item name="android:paddingRight">16dp</item>
    </style>
    <style name="PreferenceFragmentList.Material">
        <item name="android:paddingLeft">0dp</item>
        <item name="android:paddingRight">0dp</item>
    </style>
  

• v1.2.1:

    <style name="PreferenceFragment">
        <item name="android:paddingLeft">0dp</item>
        <item name="android:paddingStart">0dp</item>
        <item name="android:paddingRight">0dp</item>
        <item name="android:paddingEnd">0dp</item>
        <item name="android:divider">?android:attr/listDivider</item>
    </style>
    <style name="PreferenceFragmentList">
        <item name="android:paddingLeft">16dp</item>
        <item name="android:paddingStart">16dp</item>
        <item name="android:paddingRight">16dp</item>
        <item name="android:paddingEnd">16dp</item>
    </style>
    <style name="PreferenceFragmentList.Material">
        <item name="android:paddingLeft">0dp</item>
        <item name="android:paddingStart">0dp</item>
        <item name="android:paddingRight">0dp</item>
        <item name="android:paddingEnd">0dp</item>
    </style>
  

It seems that now the android:paddingLeft and the android:paddingRight take preference over the android:paddingStart and android:paddingEnd