cinterpop tasks overlap in outputs [308798582]

Assigned

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Nov 1, 2023 05:25PM

org.gradle.api.GradleException: Output file $SUPPORT/.gradle/kotlin/kotlinTransformedCInteropMetadataLibraries was declared as an output of multiple tasks: task ':benchmark:benchmark-darwin:transformDarwinMainCInteropDependenciesMetadataForIde' and task ':annotation:annotation:transformNonJvmMainCInteropDependenciesMetadataForIde'
at androidx.build.ListTaskOutputsTaskKt.findAllTasksByOutput(ListTaskOutputsTask.kt:139)
at androidx.build.ListTaskOutputsTask.computeOutputText(ListTaskOutputsTask.kt:95)
at androidx.build.ListTaskOutputsTask$outputText$2.invoke(ListTaskOutputsTask.kt:37)
at androidx.build.ListTaskOutputsTask$outputText$2.invoke(ListTaskOutputsTask.kt:37)
at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
at androidx.build.ListTaskOutputsTask.getOutputText(ListTaskOutputsTask.kt:37)
at androidx.build.ListTaskOutputsTask._init_$lambda$0(ListTaskOutputsTask.kt:43)
at jdk.proxy1/jdk.proxy1.$Proxy89.graphPopulated(Unknown Source)

when trying to enable kotlin native by default https://android-build.corp.google.com/artifact/pending/P64845233/androidx_incremental/latest/view/logs%2Fbuild_error.log

when enabling kotlin native by default in aosp/2800737

Comments

au...@google.com <au...@google.com> #2Nov 1, 2023 05:34PM

Specifically this version is 3.22.3 and should be 3.25.5 or later to pick up the patch.

https://github.com/androidx/androidx/blob/50cc79c8f51904c183e97e605b8620b3ba0a5009/buildSrc/shared-dependencies.gradle#L50

au...@google.com <au...@google.com> #3Nov 1, 2023 05:39PM

It seems that maybe upstream task just always uses this shared directory without specifying subdirectories/files within it

https://cs.android.com/android-studio/kotlin/+/master:libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/internal/CInteropMetadataDependencyTransformationTask.kt;l=82?q=kotlinTransformedCInteropMetadataLibraryDirectoryForIde&sq=&ss=android-studio

ap...@google.com <ap...@google.com> #4Nov 2, 2023 10:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 069a172295fa15699bfd8f211fa85d5920fe43cb
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Nov 02 14:22:06 2023

Add listTaskOutputs to multiplatform targets

This task ensures that the task outputs are compliant to our
build rules.

Test: None
Bug: 308798582
Change-Id: I8a4cebde33e42fd8a7860c4b2b7d354f35d1acab

M buildSrc/private/src/main/kotlin/androidx/build/ListTaskOutputsTask.kt
M busytown/androidx_multiplatform_linux.sh
M busytown/androidx_multiplatform_mac.sh

https://android-review.googlesource.com/2813279

ap...@google.com <ap...@google.com> #5Nov 9, 2023 12:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit 1bd89fe66d162edba60484d2dcce32b72bb67cbf
Author: Yigit Boyar <yboyar@google.com>
Date: Wed Nov 08 09:15:59 2023

Fix mac build

Opt-in to cinterop APIs that became experimental in 1.9.20
(ExperimentalForeignApi)

Migrate to use CPointer instead of underlying type in SQLite native.
It avoids the .pointed and .ptr back-and-forth and is compatible with Kotlin 1.9.0 changes.

Remove KMP mem allocator override
This was only necessary for overiding mimalloc since it wasn't supported
on Android, but we can now rely on the default custom memory allocator
in 1.9.20 instead, which will also have better performance.

Added a workaround for metadata generation in the benchmark plugin:
KT-42387

Bug: 308798582
Test: NativeSQLiteDriverTest
Test: CI
Change-Id: I500bfcce6fad7a36761fc22fd88aef2b8f223868

M benchmark/benchmark-darwin-samples/build.gradle
M benchmark/benchmark-darwin/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/ListTaskOutputsTask.kt
M collection/collection-benchmark/build.gradle
M collection/collection/build.gradle
M sqliteMultiplatform/sqlite-driver/src/nativeMain/kotlin/androidx/sqliteMultiplatform/driver/NativeSQLiteConnection.kt
M sqliteMultiplatform/sqlite-driver/src/nativeMain/kotlin/androidx/sqliteMultiplatform/driver/NativeSQLiteDriver.kt
M sqliteMultiplatform/sqlite-driver/src/nativeMain/kotlin/androidx/sqliteMultiplatform/driver/NativeSQLiteStatement.kt

https://android-review.googlesource.com/2822875

yb...@google.com <yb...@google.com> #6Nov 9, 2023 12:50AM

this should be fixed for now, still havent' created a bug on youtrack.

au...@google.com <au...@google.com> #7Jul 22, 2024 06:46PM

Reassigned to da...@google.com.

danysantiago@ can you file an upstream bug about this so that jetbrains can be more specific about their output directories instead of sharing them.

Issue 308798582