Status Update
Comments
pa...@gmail.com <pa...@gmail.com> #2
This is a particularly hard device to come by - do you happen to have access to the device? If so could you provide us with the output of: adb shell dumpsys media.camera > info.txt
Thanks!
wu...@google.com <wu...@google.com> #3
Stacktrace:
Caused by: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes(SupportedSurfaceCombination.java:355)
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions(SupportedSurfaceCombination.java:197)
at androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions(Camera2DeviceSurfaceManager.java:198)
at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:943)
at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:293)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:227)
Below are some findings based on our debugging
When Dex is connected
previewConfig.getMaxResolution() is returning "731x411" as maxSize.
Inside Preview.Builder.build() -> Default_MAX_resolution is set to "CameraX.getSurfaceManager().getPreviewSize()" which is 731x411
this is being picked as maxSize.
While rendering maxSize is 731x411 and minSize is 640x480 and below are available outputSizes
0 = {Size@11860} "4032x3024"
1 = {Size@11861} "3984x2988"
2 = {Size@11862} "4032x2268"
3 = {Size@11863} "3024x3024"
4 = {Size@11864} "2976x2976"
5 = {Size@11865} "3840x2160"
6 = {Size@11866} "3264x2448"
7 = {Size@11867} "4032x1960"
8 = {Size@11868} "2880x2160"
9 = {Size@11869} "3264x1836"
10 = {Size@11870} "2160x2160"
11 = {Size@11871} "2560x1440"
12 = {Size@11872} "2224x1080"
13 = {Size@11873} "2048x1152"
14 = {Size@11874} "1920x1080"
15 = {Size@11875} "1440x1080"
16 = {Size@11876} "1088x1088"
17 = {Size@11877} "1280x720"
18 = {Size@11878} "1024x768"
19 = {Size@11879} "1056x704"
20 = {Size@11880} "960x720"
21 = {Size@11881} "960x540"
22 = {Size@11882} "720x720"
23 = {Size@11883} "800x450"
24 = {Size@11884} "720x480"
25 = {Size@11885} "640x480"
26 = {Size@11886} "352x288"
27 = {Size@11887} "320x240"
28 = {Size@11888} "256x144"
29 = {Size@11889} "176x144"
and couldn't find any size in this range.
When Dex not connected
minsize = 640x480
maxsize = 1920x1080
0 = {Size@11836} "4032x3024"
1 = {Size@11837} "3984x2988"
2 = {Size@11838} "4032x2268"
3 = {Size@11839} "3024x3024"
4 = {Size@11840} "2976x2976"
5 = {Size@11841} "3840x2160"
6 = {Size@11842} "3264x2448"
7 = {Size@11843} "4032x1960"
8 = {Size@11844} "2880x2160"
9 = {Size@11845} "3264x1836"
10 = {Size@11846} "2160x2160"
11 = {Size@11847} "2560x1440"
12 = {Size@11848} "2224x1080"
13 = {Size@11849} "2048x1152"
14 = {Size@11850} "1920x1080"
15 = {Size@11851} "1440x1080"
16 = {Size@11852} "1088x1088"
17 = {Size@11853} "1280x720"
18 = {Size@11854} "1024x768"
19 = {Size@11855} "1056x704"
20 = {Size@11856} "960x720"
21 = {Size@11857} "960x540"
22 = {Size@11858} "720x720"
23 = {Size@11859} "800x450"
24 = {Size@11860} "720x480"
25 = {Size@11861} "640x480"
26 = {Size@11862} "352x288"
27 = {Size@11863} "320x240"
28 = {Size@11864} "256x144"
29 = {Size@11865} "176x144"
and we have 12 available sizes in this range
Camera2DeviceSurfaceManager.java:: getPreviewSize()
mCameraSupportedSurfaceCombinationMap.get(cameraId).getSurfaceDefinition().getPreviewSize() = "1920x1080"
cameraId=0
wu...@google.com <wu...@google.com>
pa...@gmail.com <pa...@gmail.com> #4
The issue root cause is that CameraX will default filter out sizes smaller than 640x480. For Preview, the max size will be limited to under display size. I checked the HW spec info for the issue related devices. Display size of FUJITSU F-04J/F-05J is 360x640. That will result int that no size exists in the conditions that is larger or equal to 640x480 and smaller or equal to 360x640.
A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
For device FUJITSU arrowsM04, I checked its HW spec info and its display size I found is 1280x720. It seems that the problem should not exist in the device.
Could you confirm that the problem exist on arrowsM04 device? What will be the returned value when using Display#getRealSize to obtain the display size?
wu...@google.com <wu...@google.com> #5
> A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
OK. I will try it.
> Could you confirm that the problem exist on arrowsM04 device?
We receive the crash report (Crashlytics) that this crash has occurred on arrowsM04.
We don't have this device so we can't confirm that the problem really exist on arrowsM04.
> What will be the returned value when using Display#getRealSize to obtain the display size?
We can't investigate it for the same reason.
Thank you.
wu...@google.com <wu...@google.com>
ch...@google.com <ch...@google.com> #6
This issue happened on devices that the display size is smaller than 640x480. In original auto-resolution mechanism, supported sizes smaller than 640x480 will be default filter out.
The auto-resolution mechanism encodes the guaranteed configurations tables in CameraDevice#createCaptureSession(SessionConfiguration). It defines that the PREVIEW size is the small one of the device display size and 1080p. The PREVIEW size will be the maximal size limitation for Preview use case. The reason it limits the size to display size and 1080p is the stream output in display size or 1080p has been able to provide good enough preview quality. Therefore, auto-resolution mechanism will limit the selected size to be smaller than the small one of the device display size and 1080p.
With above two conditions, in this issue, all sizes smaller than 640x480 have been filter out, therefore, there is no size smaller than the display size 320x240 can be selected to use. And cause the exception.
Solution:
When the display size is smaller than 640x480, auto-resolution mechanism won't filter out those small sizes smaller than 640x480. This makes those small size be left and can be selected for the Preview use case on small display devices.
The solution has been merged and will be included in next CameraX release.
pa...@gmail.com <pa...@gmail.com> #7
Hello.
This crash still occurs.
- CAMERAX VERSION: 1.0.0-beta4
- ANDROID OS BUILD NUMBER: Android 7.1.1
- DEVICE NAME: FUJITSU F-02H
We receive following crash report from FUJITSU F-02H. So far We have received this crash report only from F-02H.
java.lang.IllegalArgumentException
Can not get supported output size under supported maximum for the format: 34
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes (SupportedSurfaceCombination.java:349)
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions (SupportedSurfaceCombination.java:197)
androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions (Camera2DeviceSurfaceManager.java:198)
androidx.camera.core.CameraX.calculateSuggestedResolutions (CameraX.java:949)
androidx.camera.core.CameraX.bindToLifecycle (CameraX.java:351)
androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle (ProcessCameraProvider.java:230)
(our application's package name).CameraFragment.bindCameraUseCases (CameraFragment.java:174)
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #8
Could you help to provide the following information to clarify the issue?
1. Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
2. Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
ch...@google.com <ch...@google.com> #9
- Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
Yes
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
Since we don't have this device, we'll try to collect this information in the next version of our app. The next version will be released later this month.
pa...@gmail.com <pa...@gmail.com> #10
Hello.
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
We have collected the output of the device where the crash occurs.
Device1
- Model : arrows Be F-05J
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Device2
- Model : Fujitsu arrows M04
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Additional Information
CameraX version : 1.0.0-beta04
We collect the supported output sizes by following code.
val errorString = buildString {
append("The supported output sizes of ImageFormat.PRIVATE: ")
(requireContext().getSystemService(Context.CAMERA_SERVICE) as CameraManager).apply {
cameraIdList.forEachIndexed { index, cameraId ->
val msg = if (VERSION.SDK_INT >= VERSION_CODES.M) {
val configurationMap =
getCameraCharacteristics(cameraId).get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val sizes = configurationMap?.getOutputSizes(ImageFormat.PRIVATE)
"CameraId $index: ${sizes?.joinToString(" ,")}"
} else {
"CameraId $index: This device version is under M."
}
append(msg)
}
}
}
pa...@gmail.com <pa...@gmail.com> #11
ch...@google.com <ch...@google.com> #12
I tried to find the device specs and both 720x1280
size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480
but the device only supports a 480x480
size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04
release. Before 480x480
size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480
size threshold was removed and then the 480x480
size would be kept and selected to use.
It looks like 1.0.0-beta04
release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04
release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04
version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01
version for your application. Thanks.
pa...@gmail.com <pa...@gmail.com> #13
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10
and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J
or Fujitsu arrows M04
so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
ch...@google.com <ch...@google.com> #14
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
ch...@google.com <ch...@google.com> #15
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
pa...@gmail.com <pa...@gmail.com> #16
ch...@google.com <ch...@google.com> #17
Hi,
-
Just want to confirm that you did see the
for the setBufferFormat related issue.comment14 -
After investigating and testing, I found that the captured JPEG byte array can be correctly decoded by removing some data in the head. I'm trying to fix the issue in CameraX side. But it might take some time and the solution will only be included in 1.4.0-alpha version releases. If your app needs to use stable version like 1.3.0, please try the following steps to workaround this issue.
2.1 For the A24 devices, taking picture by the
in-memory approach.ImageCapture#takePicture(java.util.concurrent.Executor,androidx.camera.core.ImageCapture.OnImageCapturedCallback) 2.2 When receiving the ImageProxy from the OnImageCapturedCallback, trying to find the second
ffd8
marker position.Take IMG_2023_11_08_17_33_21_398.jpg as example:
0000000 d8ff e1ff 7cff 7845 6669 0000 4949 002a <-- In the beginning, the JPEG byte data starts from a `ffd8` ... 0000580 d8ff e0ff 1000 464a 4649 0100 0001 0100 <-- In position 0x0000580, another `ffd8` occurs
2.3 Only write the byte data from the second
ffd8
to the end to the output jpeg file.
Please let me know whether any of the above two approaches can fix the issue in your side. Thanks.
pa...@gmail.com <pa...@gmail.com> #18
we tried with the first option of removing ImageAnalyzer(as suggested in comment no. #14) while creating the camera object and setting the buffer format in ImageCaptureBuilder(as suggested in comment no. #12) as shown below -
ImageCapture imageCapture = new ImageCapture.Builder()
.setBufferFormat(ImageFormat.YUV_420_888)
.build()
We have tested with this fix and we are not getting crash for the Images we were getting previous to this fix. We are releasing temp fix for this specific devices in our app. I will share feedback once app goes live. Thanks for your prompt response and support.
ch...@google.com <ch...@google.com> #19
Hi,
Could you help to try the attached CameraXBasic apk which was built with the JPEG metadata correction solution? Please also help to check the following log is printed to ensure the solution is loaded.
JpegMetadataCorrector is loaded!
Thanks.
ch...@google.com <ch...@google.com> #20
Re-upload the correct APK because the previous one has some problem which the workaround can't be correctly loaded on A24 devices.
pa...@gmail.com <pa...@gmail.com> #21
I have installed the above app on Samsung A 24 device and tried to take pictures but all images - (simple as well as images having complex colors) are getting corrupted and able to see blank images.
and yes the log is getting printed - JpegMetadataCorrector is loaded!
Sharing the video for example -
Logs of device session from android studio -
ch...@google.com <ch...@google.com> #22
Hi,
Thanks for providing the info. From the log, I can only see some luminosity related log. I can't find the
A24IssueTag D IncorrectJpegMetadataQuirk is loaded!
A24IssueTag D canParseSosMarker: false <= To know whether JPEG SOS marker can be parsed successfully from the original JPEG byte data
A24IssueTag D Success to decode the processed byte data! size: 4032x2268, decoding took 128 ms! <= To know whether the JPEG byte data processed by the quirk can be successfully decoded to bitmap or not
Thanks.
ap...@google.com <ap...@google.com> #23
Branch: androidx-main
commit 82cc306db3df0b49c5facc265f8f32a86dd5afa1
Author: CharcoalChen <charcoalchen@google.com>
Date: Wed Nov 15 17:55:05 2023
Fix the incorrect JPEG image metadata issue on Samsung A24 devices
Some unexpected data exists in the head of the problematic JPEG images captured from the Samsung A24 devices. Removing those data can fix the JPEG images.
Relnote: "Fixed the incorrect JPEG image metadata issue on Samsung A24 devices. With the fix, CameraX can successfully save the JPEG image, or correct Bitmap objects can be returned when calling the ImageProxy.toBitmap() function on Samsung A24 devices."
Bug: 309005680
Test: ./gradlew bOS
Change-Id: I8d6eb3b4cc6f68237248cda566f0b9742f98862d
M camera/camera-core/src/androidTest/java/androidx/camera/core/imagecapture/Image2JpegBytesDeviceTest.kt
M camera/camera-core/src/androidTest/java/androidx/camera/core/imagecapture/ProcessingNodeDeviceTest.kt
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/Image2JpegBytes.java
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/ProcessingNode.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/DeviceQuirks.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/IncorrectJpegMetadataQuirk.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/workaround/JpegMetadataCorrector.java
M camera/camera-core/src/test/java/androidx/camera/core/imagecapture/Image2JpegBytesTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/imagecapture/ProcessingNodeTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/internal/compat/quirk/DeviceQuirks.java
A camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/JpegMetadataCorrectorTest.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/TestImageUtil.java
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #24
Update some info from Samsung about this issue. Samsung had found this issue and had their FOTA plans to fix this issue. The schedule might vary with regions and carriers. Once the end users' device get new available FOTA ROM, please update it to get the fix. Thanks.
na...@google.com <na...@google.com> #25
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.3.2
na...@google.com <na...@google.com> #26
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.4.0-alpha05
pr...@paralleldots.com <pr...@paralleldots.com> #27
Crash log :
Fatal Exception: java.lang.UnsupportedOperationException
Decode jpeg byte array failed
androidx.camera.core.internal.utils.ImageUtil.createBitmapFromJpegImage (ImageUtil.java:453)
androidx.camera.core.ImageProxy.toBitmap (ImageProxy.java:154)
When will this be fixed for this device?
Description
def camerax_version = '1.1.0-beta01' and camerax_version = "1.1.0"
CAMERA APPLICATION NAME AND VERSION: -App Name: Camera & Version: 13.1.00.80
ANDROID OS BUILD NUMBER: TP1A.220624.014.A245FXXS3AWH4
DEVICE NAME: (Samsung A24)
DESCRIPTION:
We are using in our app camerax2 API for clicking images but recently observed the issue of image corruption on Specific samsung device and that too on images which have more objects and image reflection. One sample image attached here. When we debugged we are getting IO Exception in Imagecapture callback.
Our client have 100s of this kind of device and facing issue. Image are getting corrupted and getting exception.
Please let us know if you need any inputs from our end.
LIST ANY EXPERIMENTAL FEATURES: no experimental feature used
STEPS TO REPRODUCE:
1. Open camera
2. Click photo attached in attachments
OBSERVED RESULTS:
Image is not getting saved and corrupted and getting Exception - ImageCaptureException - IO issue not able to save temp(raw image) file.
EXPECTED RESULTS: App should not get the exception and should save in device the image as well show in image preview.
REPRODUCIBILITY: 4 out of 5 if used similar images having lot of objects and light reflection
ADDITIONAL INFORMATION: The same issue happening in sample app given by google for camera2 API and cameraxBasic sample app
CODE FRAGMENTS (this will help us troubleshoot your issues):
public void capturePhoto() {
long timeStamp = System.currentTimeMillis();
ContentValues contentValues = new ContentValues();
contentValues.put(MediaStore.MediaColumns.DISPLAY_NAME,timeStamp);
contentValues.put(MediaStore.MediaColumns.MIME_TYPE,"image/jpeg");
if (cameraProvider == null) {
if (ownCameraXListeners != null) {
ownCameraXListeners.cameraNotAvailable();
}
return;
}
// Get a stable reference of the modifiable image capture use case
// Create output options object which contains file + metadata
ImageCapture.OutputFileOptions outputOptions = new ImageCapture.OutputFileOptions.Builder(
context.getContentResolver(),
MediaStore.Images.Media.EXTERNAL_CONTENT_URI,
contentValues
).build();
if (flashEnabled) {
imageCapture.setFlashMode(ImageCapture.FLASH_MODE_ON);
} else {
imageCapture.setFlashMode(ImageCapture.FLASH_MODE_OFF);
}
imageCapture.setTargetRotation(surfaceRotation);
// Set up image capture listener, which is triggered after photo has
// been taken
Log.i("capture","clicked");
imageCapture.takePicture(
outputOptions, executor , new ImageCapture.OnImageSavedCallback() {
@Override
public void onImageSaved(@NonNull ImageCapture.OutputFileResults outputFileResults) {
Log.i("capture","callback onImageSaved started");
InputStream iStream;
byte[] inputData;
try {
iStream = context.getContentResolver().openInputStream(Uri.fromFile(tempCapturedFile));
inputData = getBytes(iStream);
if (ownCameraXListeners != null) {
ownCameraXListeners.onPictureTaken(tempCapturedFile);
}
} catch (Exception e) {
e.printStackTrace();
FirebaseCrashlytics.getInstance().recordException(e);
if(ownCameraXListeners!=null){
ownCameraXListeners.onPictureTakenError(e);
}
}
}
@Override
public void onError(@NonNull ImageCaptureException e) {
e.printStackTrace();
FirebaseCrashlytics.getInstance().recordException(e);
if(ownCameraXListeners!=null){
ownCameraXListeners.onPictureTakenError(e);
}
}
});
}