Migrate implementation to use platform-provided CancellationSignal [309499026]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

al...@google.com

created issue #1

Nov 6, 2023 08:23PM

AndroidX has increased the global minSdk to 19, which means the Fragment library can use android.os.CancellationSignal instead of androidx.core.os.CancellationSignal.

This might be difficult, though, because there is an internal API surface shared between Fragment and Transition library that uses the compat class.

Comments

il...@google.com <il...@google.com> #2Nov 8, 2023 11:49PM

Assigned to cl...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Nov 9, 2023 10:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9256ab480ddd54cab14b08ff9f8872df5689a3f6
Author: Alan Viverette <alanv@google.com>
Date: Mon Nov 06 16:25:08 2023

Deprecate androidx.core.os.CancellationSignal

Relnote: "Deprecated `androidx.core.os.CancellationSignal`. Usages should
be replaced with the platform-provided `android.os.CancellationSignal`."
Bug: 309499026
Fixes: 309054079
Test: LocationManagerCompatTest
Change-Id: Id45f69a0b9cee7515d3f5b35dde3b3b037f8bd3a

M core/core/api/api_lint.ignore
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/location/LocationManagerCompatTest.java
M core/core/src/main/java/androidx/core/content/ContentResolverCompat.java
M core/core/src/main/java/androidx/core/hardware/fingerprint/FingerprintManagerCompat.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
M core/core/src/main/java/androidx/core/os/CancellationSignal.java
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionCompat21.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionImpl.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
M loader/loader/build.gradle
M loader/loader/src/main/java/androidx/loader/content/CursorLoader.java
M transition/transition/src/main/java/androidx/transition/FragmentTransitionSupport.java

https://android-review.googlesource.com/2824570

ap...@google.com <ap...@google.com> #4Dec 13, 2023 12:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3dd7c8e75663e49739a7758a17bc23b344a52cf6
Author: Ian Lake <ilake@google.com>
Date: Tue Dec 12 23:57:39 2023

Remove unused completeSpecialEffect() method

And with that method, a reference to the deprecated
AndroidX CancellationSignal.

BUG: 309499026
Test: ./gradlew bOS
Change-Id: I7be18eff5d355a1247a408b3dfbf8055aa042520

M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt

https://android-review.googlesource.com/2871639

il...@google.com <il...@google.com> #5Dec 13, 2023 04:50PM

Marked as fixed, reassigned to il...@google.com.

The only remaining usages of androidx.core.os.CancellationSignal in Fragment are baked into the public API between the Fragment and Transition library that cannot be removed without breaking binary compatibility between those modules.

Since we'll need to keep those APIs in place ~forever, we've removed everything possible.

Issue 309499026

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Nov 8, 2023 11:49PM

ap...@google.com <ap...@google.com> #3Nov 9, 2023 10:51PM

ap...@google.com <ap...@google.com> #4Dec 13, 2023 12:46AM

il...@google.com <il...@google.com> #5Dec 13, 2023 04:50PM

Add comment

Issue metadata