Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
which means the Fragment library can use android.os.CancellationSignal
Yes, within Fragment itself, this seems like a straightforward change.
This might be difficult, though, because there is an internal API surface shared between Fragment and Transition library that uses the compat class.
We won't be breaking the compatibility between these libraries, so these usages will likely have to remain ~forever.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 9256ab480ddd54cab14b08ff9f8872df5689a3f6
Author: Alan Viverette <alanv@google.com>
Date: Mon Nov 06 16:25:08 2023
Deprecate androidx.core.os.CancellationSignal
Relnote: "Deprecated `androidx.core.os.CancellationSignal`. Usages should
be replaced with the platform-provided `android.os.CancellationSignal`."
Bug: 309499026
Fixes: 309054079
Test: LocationManagerCompatTest
Change-Id: Id45f69a0b9cee7515d3f5b35dde3b3b037f8bd3a
M core/core/api/api_lint.ignore
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/location/LocationManagerCompatTest.java
M core/core/src/main/java/androidx/core/content/ContentResolverCompat.java
M core/core/src/main/java/androidx/core/hardware/fingerprint/FingerprintManagerCompat.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
M core/core/src/main/java/androidx/core/os/CancellationSignal.java
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionCompat21.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionImpl.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
M loader/loader/build.gradle
M loader/loader/src/main/java/androidx/loader/content/CursorLoader.java
M transition/transition/src/main/java/androidx/transition/FragmentTransitionSupport.java
https://android-review.googlesource.com/2824570
Branch: androidx-main
commit 9256ab480ddd54cab14b08ff9f8872df5689a3f6
Author: Alan Viverette <alanv@google.com>
Date: Mon Nov 06 16:25:08 2023
Deprecate androidx.core.os.CancellationSignal
Relnote: "Deprecated `androidx.core.os.CancellationSignal`. Usages should
be replaced with the platform-provided `android.os.CancellationSignal`."
Bug: 309499026
Fixes: 309054079
Test: LocationManagerCompatTest
Change-Id: Id45f69a0b9cee7515d3f5b35dde3b3b037f8bd3a
M core/core/api/api_lint.ignore
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/location/LocationManagerCompatTest.java
M core/core/src/main/java/androidx/core/content/ContentResolverCompat.java
M core/core/src/main/java/androidx/core/hardware/fingerprint/FingerprintManagerCompat.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
M core/core/src/main/java/androidx/core/os/CancellationSignal.java
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionCompat21.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionImpl.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
M loader/loader/build.gradle
M loader/loader/src/main/java/androidx/loader/content/CursorLoader.java
M transition/transition/src/main/java/androidx/transition/FragmentTransitionSupport.java
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 3dd7c8e75663e49739a7758a17bc23b344a52cf6
Author: Ian Lake <ilake@google.com>
Date: Tue Dec 12 23:57:39 2023
Remove unused completeSpecialEffect() method
And with that method, a reference to the deprecated
AndroidX CancellationSignal.
BUG: 309499026
Test: ./gradlew bOS
Change-Id: I7be18eff5d355a1247a408b3dfbf8055aa042520
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
https://android-review.googlesource.com/2871639
Branch: androidx-main
commit 3dd7c8e75663e49739a7758a17bc23b344a52cf6
Author: Ian Lake <ilake@google.com>
Date: Tue Dec 12 23:57:39 2023
Remove unused completeSpecialEffect() method
And with that method, a reference to the deprecated
AndroidX CancellationSignal.
BUG: 309499026
Test: ./gradlew bOS
Change-Id: I7be18eff5d355a1247a408b3dfbf8055aa042520
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.kt
il...@google.com <il...@google.com> #5
The only remaining usages of androidx.core.os.CancellationSignal
in Fragment are baked into the public API between the Fragment and Transition library that cannot be removed without breaking binary compatibility between those modules.
Since we'll need to keep those APIs in place ~forever, we've removed everything possible.
Description
AndroidX has increased the global
minSdk
to 19, which means the Fragment library can useandroid.os.CancellationSignal
instead ofandroidx.core.os.CancellationSignal
.This might be difficult, though, because there is an internal API surface shared between Fragment and Transition library that uses the compat class.