Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Use Markdown for this comment
Set severity, which reflects how much the issue affects the use of the product
Change issue status back to 'Assigned'
Pending code changes (auto-populated)
[ID: 84651]
Story points rate the relative effort of work in a Fibonacci-like format: 0, 0.5, 1, 2, 3, 5, 8, 13, 20, 40, 100. Each team will estimate work on a slightly different scale, which means the values in this field are likely only meaningful to the team that owns the Buganizer component in which the issue resides.
See Atlassian's Agile Coach for more information on how to use story points for estimation: https://www.atlassian.com/agile/project-management/estimation [ID: 746686]
Set the version(s) of the product affected by this issue (comma-separated list)
Set the version(s) of the product in which the issue should be fixed (comma-separated list)
Set the version(s) of the product in which the issue fix was verified (comma-separated list)
Set if this issue occurs in production
[ID: 85206]
Set Reporter
Set Type
Set priority, which reflects how soon the issue should be fixed
Set Status
Set Assignee
Set Verifier
Remove item
View or edit staffing
View issue level access limits(Press Alt + Right arrow for more information)
Description
#1Version used: 2.5.3
Devices/Android versions reproduced on: Any
When popping the back stack with saveState=true, destinations are only added to backStackMap if they are not already present (courtesy of the takeWhile operations in popBackStackInternal). The savedState array is subsequently added to backStackStates regardless. In the case that no destinations are added to backStackMap, the savedState array subsequently becomes unreachable/unrestorable, as there is no reference to the back stack name/uuid key anywhere.
To reproduce the issue:
(1) Launch the NavigationAdvancedSample app in debug mode
(2) Repeat the following several times:
(a) Tap the "About" button to navigate to the about screen
(b) Tap the "Leaderboard" bottom navigation item to navigate to the leaderboard screen
(b) Tap the back button or swipe back to navigate to the title screen again
(3) After several repeats, inspect the navController's backStackStates (which will be sizeable) and backStackMap (the values of which will not contain most of backStackStates' keys, rendering them indefinitely unreachable in restoreStateInternal
Potential fix:
Make "backStackStates[firstState.id] = savedState" conditional on at least one addition to backStackMap