R8 causing interface change to inaccessible interface [309727365]

Verified

Bug

Status Update

No update yet.

Description

an...@airbnb.com

created issue #1

Nov 8, 2023 05:12PM

Some random unrelated code led to an interface substitution that is inaccessible from the callsite.

I attached a processed binary and dump files for the issue.

In there you can see that after R8:

```
package com.airbnb.android.feat.notificationcenter.view;

import com.airbnb.epoxy.i;
import com.airbnb.epoxy.m0;

/* loaded from: classes4.dex */
public final class c implements i {
```

With `com.airbnb.android.feat.notificationcenter.view.c` mapping to `com.airbnb.android.feat.notificationcenter.view.NotificationCenterEpoxyControllerV3$onAttachedToRecyclerView$1`
and `com.airbnb.epoxy.i` mapping to `com.airbnb.epoxy.BaseEpoxyTouchCallback`

`com.airbnb.epoxy.i` is package private and thus cannot be accessed in `com.airbnb.android.feat.notificationcenter.view`, which will lead to a crash.

Originally `c` was extending the public class `com.airbnb.epoxy.EpoxyTouchHelper.SwipeCallbacks` which itself implements the public interface com.airbnb.epoxy.EpoxySwipeCallback` which then extends the package private com.airbnb.epoxy.BaseEpoxyTouchCallback`.

Let me know if I can provide any additional information

------------------

Studio Build: CLI build not relevant
R8 version: 8.1.70 (build 7cf56b7ca0dd612cb0d0cee7e8b806d095a6d4e7 from go/r8bot (luci-r8-custom-ci-focal-8-4dja))
Version of Gradle Plugin: 8.1.1
Version of Gradle: 8.3
Version of Java: OpenJDK 64-Bit Server VM Corretto-17.0.9.8.1 (build 17.0.9+8-LTS, mixed mode, sharing)
OS: Mac OS Sonoma 14.1

https://drive.google.com/file/d/1Zc-uIU_tfZPeYGhuWrNEPK3F6yh6B6wd/view?usp=drive_web (r8_dump.zip)

https://drive.google.com/file/d/1ebf6hZTfRV47QeeAttd-a3W4lz1EPFD2/view?usp=drive_web (airbnb-999999-fullGlobal-release.apk.zip)

Comments

ra...@google.com <ra...@google.com> Nov 8, 2023 07:12PM

Assigned to an...@google.com.

ch...@google.com <ch...@google.com> Nov 9, 2023 07:50AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Nov 9, 2023 01:26PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

ap...@google.com <ap...@google.com> #3Nov 9, 2023 01:55PM

Almost 2 months later and this is still broken

ap...@google.com <ap...@google.com> #4Nov 9, 2023 01:55PM

Marked as fixed.

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

ap...@google.com <ap...@google.com> #5Nov 10, 2023 09:41AM

jb...@google.com What is the update on this?

ap...@google.com <ap...@google.com> #6Nov 10, 2023 09:41AM

What is the status of this item?

ap...@google.com <ap...@google.com> #7Nov 10, 2023 09:41AM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

ap...@google.com <ap...@google.com> #8Nov 10, 2023 10:02AM

Any ETA on next release?

ap...@google.com <ap...@google.com> #9Nov 10, 2023 10:02AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ap...@google.com <ap...@google.com> #10Nov 10, 2023 10:02AM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

ap...@google.com <ap...@google.com> #11Nov 10, 2023 10:03AM

Hi, is there any update to this issue? Thanks.

ap...@google.com <ap...@google.com> #12Nov 10, 2023 10:04AM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

ap...@google.com <ap...@google.com> #13Nov 10, 2023 10:04AM

Yeah, still not fixed --'

an...@airbnb.com <an...@airbnb.com> #14Nov 16, 2023 12:27AM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

ch...@google.com <ch...@google.com> Nov 16, 2023 07:38AM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #15Jan 3, 2024 06:01PM

Any updates on this? The help for this command clearly states this argument is supported.